From: "Christoph Schlameuss" <schlameuss@linux.ibm.com>
To: "Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Janosch Frank" <frankja@linux.vnet.ibm.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>
Cc: "KVM" <kvm@vger.kernel.org>,
"David Hildenbrand" <david@redhat.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
<linux-s390@vger.kernel.org>
Subject: Re: [PATCH] KVM: s390: improve interrupt cpu for wakeup
Date: Fri, 05 Sep 2025 09:43:37 +0200 [thread overview]
Message-ID: <DCKP5LT1UP4K.U48HFEEP8Y9J@linux.ibm.com> (raw)
In-Reply-To: <20250904113927.119306-1-borntraeger@linux.ibm.com>
With nit fixed.
Reviewed-by: Christoph Schlameuß <schlameuss@de.ibm.com>
On Thu Sep 4, 2025 at 1:39 PM CEST, Christian Borntraeger wrote:
> Turns out that picking an idle CPU for floating interrupts has some
> negative side effects. The guest will keep the IO workload on its CPU
> and rather use an IPI from the interrupt CPU instead of moving workload.
> For example a guest with 2 vCPUss and 1 fio process might run that fio on
----------------------------------^
nit: vCPUs
> vcpu1. If after diag500 both vCPUs are idle then vcpu0 is woken up. The
> guest will then do an IPI from vcpu0 to vcpu1.
>
> So lets change the heuristics and prefer the last CPU that went to
> sleep. This one is likely still in halt polling and can be woken up
> quickly.
>
> This patch shows significant improvements in terms of bandwidth or
> cpu consumption for fio and uperf workloads and seems to be a net
> win.
>
> Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> ---
> arch/s390/include/asm/kvm_host.h | 2 +-
> arch/s390/kvm/interrupt.c | 20 +++++++++-----------
> 2 files changed, 10 insertions(+), 12 deletions(-)
prev parent reply other threads:[~2025-09-05 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 11:39 [PATCH] KVM: s390: improve interrupt cpu for wakeup Christian Borntraeger
2025-09-05 7:39 ` Christian Borntraeger
2025-09-05 7:43 ` Christoph Schlameuss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCKP5LT1UP4K.U48HFEEP8Y9J@linux.ibm.com \
--to=schlameuss@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox