From: "Nico Boehr" <nrb@linux.ibm.com>
To: "Thomas Huth" <thuth@redhat.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>
Cc: <kvm@vger.kernel.org>, "Andrew Jones" <andrew.jones@linux.dev>,
"Janosch Frank" <frankja@linux.ibm.com>
Subject: Re: [kvm-unit-tests PATCH v2] scripts/arch-run.bash: Drop the dependency on "jq"
Date: Wed, 10 Sep 2025 13:36:28 +0200 [thread overview]
Message-ID: <DCP38M1VQ9IY.32HM6G6NY3ASZ@linux.ibm.com> (raw)
In-Reply-To: <5b8240d7-d3e9-4b8b-bc77-731fb2fb0001@redhat.com>
On Wed Sep 10, 2025 at 11:06 AM CEST, Thomas Huth wrote:
> On 10/09/2025 11.00, Claudio Imbrenda wrote:
>> On Wed, 10 Sep 2025 09:57:17 +0200
>> "Nico Boehr" <nrb@linux.ibm.com> wrote:
>>
>>> On Tue Sep 9, 2025 at 6:58 AM CEST, Thomas Huth wrote:
>>>> For checking whether a panic event occurred, a simple "grep"
>>>> for the related text in the output is enough - it's very unlikely
>>>> that the output of QEMU will change. This way we can drop the
>>>> dependency on the program "jq" which might not be installed on
>>>> some systems.
>>>
>>> Trying to understand which problem you're trying to solve here.
>>>
>>> Is there any major distribution which doesn't have jq in its repos? Or any
>>> reason why you wouldn't install it?
>>
>> I think it's just a matter of trying to avoid too many dependencies,
>> especially for something this trivial
>
> Yes ... actually, a while ago, I noticed that I was never running this test
> on fresh installations since "jq" is not there by default. I guess it's the
> same for many other people, too, since we don't really tell them to install
> "jq" first.
>
> So let's give this patch a try for a while, and if we run into problems, we
> can still revert it.
Acked-by: Nico Boehr <nrb@linux.ibm.com>
next prev parent reply other threads:[~2025-09-10 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 4:58 [kvm-unit-tests PATCH v2] scripts/arch-run.bash: Drop the dependency on "jq" Thomas Huth
2025-09-09 13:49 ` Claudio Imbrenda
2025-09-09 16:05 ` Andrew Jones
2025-09-10 7:57 ` Nico Boehr
2025-09-10 9:00 ` Claudio Imbrenda
2025-09-10 9:06 ` Thomas Huth
2025-09-10 11:36 ` Nico Boehr [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-31 11:05 Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCP38M1VQ9IY.32HM6G6NY3ASZ@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox