Re: [RFC 01/10] KVM: s390: diag258: Pass absolute address to kvm_is_gpa_in_memslot()

["Christoph Schlameuss" <schlameuss@linux.ibm.com>]

On Mon Mar 16, 2026 at 5:23 PM CET, Janosch Frank wrote:
> The token address is a real address and as such we need to translate
> it before it's a true gpa.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Fixes: 3c038e6be0e29 ("KVM: async_pf: Async page fault support on s390")

Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

> ---
>  arch/s390/kvm/diag.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/diag.c b/arch/s390/kvm/diag.c
> index d89d1c381522..51ba4dcc3905 100644
> --- a/arch/s390/kvm/diag.c
> +++ b/arch/s390/kvm/diag.c
> @@ -122,7 +122,7 @@ static int __diag_page_ref_service(struct kvm_vcpu *vcpu)
>  		    parm.token_addr & 7 || parm.zarch != 0x8000000000000000ULL)
>  			return kvm_s390_inject_program_int(vcpu, PGM_SPECIFICATION);
>  
> -		if (!kvm_is_gpa_in_memslot(vcpu->kvm, parm.token_addr))
> +		if (!kvm_is_gpa_in_memslot(vcpu->kvm, kvm_s390_real_to_abs(vcpu, parm.token_addr)))
>  			return kvm_s390_inject_program_int(vcpu, PGM_ADDRESSING);
>  
>  		vcpu->arch.pfault_token = parm.token_addr;