Re: [RFC 04/10] KVM: s390: kvm_s390_real_to_abs() should return gpa_t

["Christoph Schlameuss" <schlameuss@linux.ibm.com>]

On Mon Mar 16, 2026 at 5:23 PM CET, Janosch Frank wrote:
> An absolute address is definitely guest physical.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

> ---
>  arch/s390/kvm/gaccess.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/s390/kvm/gaccess.h b/arch/s390/kvm/gaccess.h
> index b5385cec60f4..ee346b607a07 100644
> --- a/arch/s390/kvm/gaccess.h
> +++ b/arch/s390/kvm/gaccess.h
> @@ -24,7 +24,7 @@
>   * Returns the guest absolute address that corresponds to the passed guest real
>   * address @gra of by applying the given prefix.
>   */
> -static inline unsigned long _kvm_s390_real_to_abs(u32 prefix, unsigned long gra)
> +static inline gpa_t _kvm_s390_real_to_abs(u32 prefix, unsigned long gra)
>  {
>  	if (gra < 2 * PAGE_SIZE)
>  		gra += prefix;
> @@ -41,8 +41,8 @@ static inline unsigned long _kvm_s390_real_to_abs(u32 prefix, unsigned long gra)
>   * Returns the guest absolute address that corresponds to the passed guest real
>   * address @gra of a virtual guest cpu by applying its prefix.
>   */
> -static inline unsigned long kvm_s390_real_to_abs(struct kvm_vcpu *vcpu,
> -						 unsigned long gra)
> +static inline gpa_t kvm_s390_real_to_abs(struct kvm_vcpu *vcpu,
> +					 unsigned long gra)

nit: This would also nicely fit into a single line (<100 c) when you are already
touching it.

>  {
>  	return _kvm_s390_real_to_abs(kvm_s390_get_prefix(vcpu), gra);
>  }