From: "Christoph Schlameuss" <schlameuss@linux.ibm.com>
To: "Janosch Frank" <frankja@linux.ibm.com>, <kvm@vger.kernel.org>
Cc: <linux-s390@vger.kernel.org>, <imbrenda@linux.ibm.com>,
<borntraeger@linux.ibm.com>, <akrowiak@linux.ibm.com>
Subject: Re: [RFC 05/10] KVM: s390: vsie: Cleanup and fixup of crycb handling
Date: Wed, 18 Mar 2026 15:13:49 +0100 [thread overview]
Message-ID: <DH5YY1OWTESZ.1IFOYUF2D630K@linux.ibm.com> (raw)
In-Reply-To: <20260316180310.17765-6-frankja@linux.ibm.com>
On Mon Mar 16, 2026 at 5:23 PM CET, Janosch Frank wrote:
> The crycbd denotes an absolute address and as such we need to use
> gpa_t and read_guest_abs() instead of read_guest_real().
>
> We don't want to copy the reserved fields into the host, so let's
> define size constants that only include the masks and ignore the
> reserved fields.
>
> While we're at it, remove magic constants with compiler backed
> constants.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> ---
> arch/s390/include/asm/kvm_host.h | 6 ++++
> arch/s390/kvm/vsie.c | 50 +++++++++++++++-----------------
> 2 files changed, 30 insertions(+), 26 deletions(-)
>
next prev parent reply other threads:[~2026-03-18 14:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 16:23 [RFC 00/10] KVM: s390: spring cleanup Janosch Frank
2026-03-16 16:23 ` [RFC 01/10] KVM: s390: diag258: Pass absolute address to kvm_is_gpa_in_memslot() Janosch Frank
2026-03-16 18:34 ` Christian Borntraeger
2026-03-17 10:01 ` Christoph Schlameuss
2026-03-18 16:04 ` Claudio Imbrenda
2026-03-16 16:23 ` [RFC 02/10] KVM: s390: Consolidate lpswe variants Janosch Frank
2026-03-16 18:47 ` Christian Borntraeger
2026-03-17 8:13 ` Janosch Frank
2026-03-17 13:03 ` [PATCH] KVM: s390: Fix lpsw/e breaking event handling Janosch Frank
2026-03-17 13:30 ` Christian Borntraeger
2026-03-23 15:08 ` Hendrik Brueckner
2026-03-16 16:23 ` [RFC 03/10] KVM: s390: Convert shifts to gpa_to_gfn() Janosch Frank
2026-03-16 18:49 ` Christian Borntraeger
2026-03-17 10:38 ` Christoph Schlameuss
2026-03-18 14:26 ` Claudio Imbrenda
2026-03-16 16:23 ` [RFC 04/10] KVM: s390: kvm_s390_real_to_abs() should return gpa_t Janosch Frank
2026-03-16 18:53 ` Christian Borntraeger
2026-03-18 7:10 ` Christoph Schlameuss
2026-03-18 14:29 ` Claudio Imbrenda
2026-03-16 16:23 ` [RFC 05/10] KVM: s390: vsie: Cleanup and fixup of crycb handling Janosch Frank
2026-03-18 14:13 ` Christoph Schlameuss [this message]
2026-03-18 16:48 ` Claudio Imbrenda
2026-03-20 12:01 ` Anthony Krowiak
2026-03-23 15:54 ` Janosch Frank
2026-03-16 16:23 ` [RFC 06/10] KVM: s390: Rework lowcore access functions Janosch Frank
2026-03-18 14:25 ` Claudio Imbrenda
2026-03-23 9:11 ` Christoph Schlameuss
2026-03-16 16:23 ` [RFC 07/10] KVM: s390: Use gpa_t and gva_t in gaccess files Janosch Frank
2026-03-18 15:36 ` Claudio Imbrenda
2026-03-23 9:10 ` Christoph Schlameuss
2026-03-16 16:23 ` [RFC 08/10] KVM: s390: Use gpa_t in priv.c Janosch Frank
2026-03-18 16:02 ` Claudio Imbrenda
2026-03-23 9:28 ` Christoph Schlameuss
2026-03-16 16:23 ` [RFC 09/10] KVM: s390: Use gpa_t in pv.c Janosch Frank
2026-03-18 15:46 ` Claudio Imbrenda
2026-03-23 9:41 ` Christoph Schlameuss
2026-03-16 16:23 ` [RFC 10/10] KVM: s390: Cleanup kvm_s390_store_status_unloaded Janosch Frank
2026-03-18 15:51 ` Claudio Imbrenda
2026-03-23 9:47 ` Christoph Schlameuss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH5YY1OWTESZ.1IFOYUF2D630K@linux.ibm.com \
--to=schlameuss@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox