From: "Julian Ruess" <julianr@linux.ibm.com>
To: "Alex Williamson" <alex@shazbot.org>,
"Julian Ruess" <julianr@linux.ibm.com>
Cc: <schnelle@linux.ibm.com>, <wintera@linux.ibm.com>,
<ts@linux.ibm.com>, <oberpar@linux.ibm.com>,
<gbayer@linux.ibm.com>, "Jason Gunthorpe" <jgg@ziepe.ca>,
"Yishai Hadas" <yishaih@nvidia.com>,
"Shameer Kolothum" <skolothumtho@nvidia.com>,
"Kevin Tian" <kevin.tian@intel.com>, <mjrosato@linux.ibm.com>,
<alifm@linux.ibm.com>, <raspl@linux.ibm.com>, <hca@linux.ibm.com>,
<agordeev@linux.ibm.com>, <gor@linux.ibm.com>,
<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-s390@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v8 2/3] vfio/ism: Implement vfio_pci driver for ISM devices
Date: Thu, 02 Apr 2026 11:06:28 +0200 [thread overview]
Message-ID: <DHIJSWHNRSRC.BDZJHUQF0K80@linux.ibm.com> (raw)
In-Reply-To: <20260401160441.406fe25a@shazbot.org>
On Thu Apr 2, 2026 at 12:04 AM CEST, Alex Williamson wrote:
> On Wed, 25 Mar 2026 14:31:24 +0100
> Julian Ruess <julianr@linux.ibm.com> wrote:
>> diff --git a/drivers/vfio/pci/ism/main.c b/drivers/vfio/pci/ism/main.c
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..00bc81f7225f806eac1b99c4520ab5a68137885e
>> --- /dev/null
>> +++ b/drivers/vfio/pci/ism/main.c
>> @@ -0,0 +1,408 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * vfio-ISM driver for s390
>> + *
>> + * Copyright IBM Corp.
>> + */
>> +
>> +#include "../vfio_pci_priv.h"
>> +#include "linux/slab.h"
>
> Convention says this should be:
>
> +#include <linux/slab.h>
> #include "../vfio_pci_priv.h"
> -#include "linux/slab.h"
>
> Without objection, I'll make the change and push this to next tomorrow.
> Thanks,
>
> Alex
Thank you very much!!
Julian
next prev parent reply other threads:[~2026-04-02 7:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 13:31 [PATCH v8 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices Julian Ruess
2026-03-25 13:31 ` [PATCH v8 1/3] vfio/pci: Rename vfio_config_do_rw() to vfio_pci_config_rw_single() and export it Julian Ruess
2026-03-25 13:31 ` [PATCH v8 2/3] vfio/ism: Implement vfio_pci driver for ISM devices Julian Ruess
2026-03-26 13:03 ` Niklas Schnelle
2026-03-26 19:05 ` Farhan Ali
2026-03-27 14:53 ` Niklas Schnelle
2026-03-30 15:36 ` Alex Williamson
2026-03-30 15:56 ` Jason Gunthorpe
2026-03-30 18:09 ` Alex Williamson
2026-03-30 18:16 ` Jason Gunthorpe
2026-03-30 18:39 ` Alex Williamson
2026-03-31 0:03 ` Jason Gunthorpe
2026-03-31 8:29 ` Niklas Schnelle
2026-03-31 20:44 ` Alex Williamson
2026-03-30 18:15 ` Niklas Schnelle
2026-04-01 16:28 ` Farhan Ali
2026-04-01 22:04 ` Alex Williamson
2026-04-02 9:06 ` Julian Ruess [this message]
2026-03-25 13:31 ` [PATCH v8 3/3] MAINTAINERS: add VFIO ISM PCI DRIVER section Julian Ruess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHIJSWHNRSRC.BDZJHUQF0K80@linux.ibm.com \
--to=julianr@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=alex@shazbot.org \
--cc=alifm@linux.ibm.com \
--cc=gbayer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=raspl@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=skolothumtho@nvidia.com \
--cc=ts@linux.ibm.com \
--cc=wintera@linux.ibm.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox