Re: [kvm-unit-tests PATCH v2 4/5] s390x: sclp: Add detection of alternate STFLE facilities

Nico Boehr
2026-04-15T11:34:15Z

On Tue Mar 24, 2026 at 4:28 PM CET, Christoph Schlameuss wrote:
[...]
> diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c
> index d624872cba608fcbbd0c482a25f091fe19475a43..77b2a5ec00d68ec7ee82da295f2f31c539b5c00c 100644
> --- a/lib/s390x/sclp.c
> +++ b/lib/s390x/sclp.c
[...]
> if (read_info->offset_cpu <= 134)
> return;
> sclp_facilities.has_diag318 = read_info->byte_134_diag318;
> +
> + if (read_info->offset_cpu <= 139)
> + return;
> + sclp_facilities.has_astfleie2 = sclp_feat_check(139, SCLP_FEAT_139_BIT_ASTFLEIE2);

Help me understand which case is the odd one, the diag318 one where we access
read_info directly or this one where we use sclp_feat_check()?

Or is there a particular reason to do it this way that I didn't see?