Re: [kvm-unit-tests PATCH v2 3/5] s390x: sclp: Rework sclp_facilities_setup() for simpler control flow

Christoph Schlameuss
2026-04-17T15:28:44Z

On Wed Apr 15, 2026 at 1:27 PM CEST, Nico Boehr wrote:
> On Tue Mar 24, 2026 at 4:28 PM CET, Christoph Schlameuss wrote:
>> Reverse the order of operations to allow for early exits with increasing
>> cpu offsets when reading facility bits in the extended range.
>
> Would be helpful to add a hint that this is needed for upcoming changes in this
> series.
>
> Otherwise LGTM.
>
> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>

Sure, wil add a note to the comment about that.