Re: [kvm-unit-tests PATCH v2 2/5] s390x: sclp: Remove unnecessary padding from struct sclp_facilities

Janosch Frank
2026-03-25T09:21:00Z

On 3/24/26 16:28, Christoph Schlameuss wrote:
> Struct sclp_facilities is only used within the guest to keep the facility
> information. Nothing bad should happen when the struct size changes in the
> future.
>
> Suggested-by: Janosch Frank <frankja@linux.ibm.com>
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

> ---
> lib/s390x/sclp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h
> index 22f120d1b7ea7d1c3fe822385d0c689e5b3459fe..42a2f2e9f25a45d3ebd71729df0d9d6d93a4fb50 100644
> --- a/lib/s390x/sclp.h
> +++ b/lib/s390x/sclp.h
> @@ -132,7 +132,6 @@ struct sclp_facilities {
> uint64_t has_kss : 1;
> uint64_t has_pfmfi : 1;
> uint64_t has_ibs : 1;
> - uint64_t : 64 - 15;
> };
>
> /* bit number within a certain byte */
>