From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1FBC7EE2E for ; Fri, 9 Jun 2023 17:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbjFIROy (ORCPT ); Fri, 9 Jun 2023 13:14:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbjFIROx (ORCPT ); Fri, 9 Jun 2023 13:14:53 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 882181FFE for ; Fri, 9 Jun 2023 10:14:44 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-256a41d3e81so863193a91.1 for ; Fri, 09 Jun 2023 10:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686330884; x=1688922884; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8Sw7MOr+3hnVEmOQlDXydslwjILda+scHccINsHsaSw=; b=mG/nfttSkrdk7C0BSGSr7wCIQeMKSTBtKlye3RaAwU6LncIf6g/898kAUadZsiYvF7 BhTF29dwuQ9nNl9vinDfD92+2MgGWOMm7zttIDy8YxDe517xcUNSl9DbkE4YxRbiys1I vOYHP+nVUrqKBaa2aPywvEWu0FyQvbZhbE7QHT5g1EobVzI/sj1wj7VExGmDGxFtQDBf r3nX/MjBQCZcP2edeA8njFSfACzGQFpjVct+LoAeQbQAcAKExT4YrtXGwvAhUva8nvSv NLLyCR0+eOSaxca/4wbZz3ndCR4g5TyLJZ6qgp+WfQ/+IRy4eqNpUIhAymSDJAjJweMY o+2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686330884; x=1688922884; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Sw7MOr+3hnVEmOQlDXydslwjILda+scHccINsHsaSw=; b=ixhK1Y0vGHIfYXij2d3Mgq0jvJ1lGlokEtgBW04kn7cUG8UC+nRR5Em3o5+kzcASvo XZk71+oBp0+pJ1aS6H1IUidpWmM1e95MO4FXGFktwfGJE2wKGkzbd3i1bxtm+KeVN5N0 Bl03EFJJc0Q9wEsOIAS9kerhnwHQb5xNzg+LVuRkAjgVTDU7UxZmxYNSw1NffrY6yJt9 B9oxIVKPSs5mAcdxG5svH9qCajY2GShb2jD4jiazRcR/PlEWIzxwoULKFHHSY0W5a6tT LW9j9YG+1/pCPbCNE+Ea9wIX/LrXRdg4zuHgrwcRma85BDt5yoD99MmBg882M4+zHGwV Krag== X-Gm-Message-State: AC+VfDwOLcFTJUmwtHjX5YicP6emmLWkecx91GmdJVBno4EQ6A+XE4E2 OPiH9b6pCZ+KY4cSwJWkXca2+DCR8S0= X-Google-Smtp-Source: ACHHUZ6LD2YKs6nr9I9wxjQHET90p4R47jYGk6zWEjv3TEEgWiIuKzmmbCdSsqb0wBL8oiyQndc+cQ== X-Received: by 2002:a17:90a:7104:b0:255:d878:704a with SMTP id h4-20020a17090a710400b00255d878704amr1861381pjk.4.1686330883399; Fri, 09 Jun 2023 10:14:43 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id b16-20020a17090a551000b0024e026444b6sm6779121pji.2.2023.06.09.10.14.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jun 2023 10:14:42 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [kvm-unit-tests PATCH v6 28/32] arm64: Add support for efi in Makefile From: Nadav Amit In-Reply-To: <20230609-2c01e3ece17d5c6b3005ee4e@orel> Date: Fri, 9 Jun 2023 10:14:31 -0700 Cc: Nikos Nikoleris , kvm@vger.kernel.org, kvmarm@lists.linux.dev, Paolo Bonzini , alexandru.elisei@arm.com, ricarkol@google.com, shahuang@redhat.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230530160924.82158-1-nikos.nikoleris@arm.com> <20230530160924.82158-29-nikos.nikoleris@arm.com> <197A5432-65EA-49A7-AD6D-1AFCB58D30D0@gmail.com> <20230609-2c01e3ece17d5c6b3005ee4e@orel> To: Andrew Jones X-Mailer: Apple Mail (2.3731.600.7) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > On Jun 9, 2023, at 12:36 AM, Andrew Jones = wrote: >=20 > On Thu, Jun 08, 2023 at 01:41:58PM -0700, Nadav Amit wrote: > ... >>> +%.efi: %.so >>> + $(call arch_elf_check, $^) >>> + $(OBJCOPY) \ >>> + -j .text -j .sdata -j .data -j .dynamic -j .dynsym \ >>> + -j .rel -j .rela -j .rel.* -j .rela.* -j .rel* -j .rela* \ >>> + -j .reloc \ >>> + -O binary $^ $@ >>=20 >> I really appreciate your work Nikos, and I might be late since I see = Drew >> already applied it to his queue. >=20 > It's not too late. arm/queue isn't stable so we can apply fixes while = it > bakes there. >=20 >> So consider this email, my previous one, and >> others that might follow more as grievances that can easily be = addressed later. >>=20 >> So: It would=E2=80=99ve been nice to keep the symbols and debug = information in a >> separate file. Something like: >>=20 >> diff --git a/arm/Makefile.common b/arm/Makefile.common >> index d60cf8c..f904702 100644 >> --- a/arm/Makefile.common >> +++ b/arm/Makefile.common >> @@ -69,7 +69,7 @@ FLATLIBS =3D $(libcflat) $(LIBFDT_archive) = $(libeabi) >> ifeq ($(CONFIG_EFI),y) >> %.so: EFI_LDFLAGS +=3D -defsym=3DEFI_SUBSYSTEM=3D0xa --no-undefined >> %.so: %.o $(FLATLIBS) $(SRCDIR)/arm/efi/elf_aarch64_efi.lds = $(cstart.o) >> - $(CC) $(CFLAGS) -c -o $(@:.so=3D.aux.o) = $(SRCDIR)/lib/auxinfo.c \ >> + $(CC) $(CFLAGS) -c -g -o $(@:.so=3D.aux.o) = $(SRCDIR)/lib/auxinfo.c \ >> -DPROGNAME=3D\"$(@:.so=3D.efi)\" = -DAUXFLAGS=3D$(AUXFLAGS) >> $(LD) $(EFI_LDFLAGS) -o $@ -T = $(SRCDIR)/arm/efi/elf_aarch64_efi.lds \ >> $(filter %.o, $^) $(FLATLIBS) $(@:.so=3D.aux.o) \ >> @@ -78,6 +78,9 @@ ifeq ($(CONFIG_EFI),y) >> %.efi: %.so >> $(call arch_elf_check, $^) >> + $(OBJCOPY) --only-keep-debug $^ $@.debug >> + $(OBJCOPY) --strip-debug $^ >> + $(OBJCOPY) --add-gnu-debuglink=3D$@.debug $^ >> $(OBJCOPY) \ >> -j .text -j .sdata -j .data -j .dynamic -j .dynsym \ >> -j .rel -j .rela -j .rel.* -j .rela.* -j .rel* -j = .rela* \ >=20 > This is nice, but I think it can wait and be posted later. >=20 Sure thing. Thanks. I still got few problems I need to finish resolving, and some other minor improvements, so I will post them all later.