From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9DCAC433E0 for ; Fri, 8 Jan 2021 16:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A4F523A04 for ; Fri, 8 Jan 2021 16:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727333AbhAHQ5K (ORCPT ); Fri, 8 Jan 2021 11:57:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbhAHQ5J (ORCPT ); Fri, 8 Jan 2021 11:57:09 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59BE1C061380 for ; Fri, 8 Jan 2021 08:56:29 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id s15so5937225plr.9 for ; Fri, 08 Jan 2021 08:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yNCtO/6yW3p5fzndxhSFUzUAHtK4RmnorBQLqNXZzV0=; b=mamyD7aVefxXHSc0LtlmG4t++ZIjOOj3QcVIfNoYoXib0ACTP6nMvBBGoLPkVxJZAD s3i+wJYwOl2/MhyDUjdRYFZ2X0CWKrubEbCny9IDjEpklBIW1CB7bNPkHp/j8EpSi2Sh G7f0CLyvv8ZZS4PulMkw77VZj5jGTMjqYhjX7z6TZTlplemr1umiN64Ga3xygEfriINH IUAh41ld264wccs6Jqk9LieoAAbCBhVvkcUrNhF5sjuubAeVZEuHVh23fzNCmJiKlxQJ exJKX9gSa3h/23/9QfVkfG7dto2KHz3CpdQeSuwPPS1uCh/hAIi5Vx+xrmDZXkOJp39/ ld/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yNCtO/6yW3p5fzndxhSFUzUAHtK4RmnorBQLqNXZzV0=; b=ihQh8ZLGdv+RDy01mpxTNB8DZIbbfqN74xCU1ac6TqugWs2IHDnBdcf7dwjZorRIFO E+usP/VGa8RAXmdWSUROR/RRVkgfQY7kXEzwOyhwFyNFrSzsKptK+Ay9yvS//EmYC56Y v1aXsXSUPBUKY+4A86hi2DizT57tMk/9AdX7HC9ZfFMYLswKNDLHYSny2r5y+bofmD6S jgVPNkbrHGQdjkyZo3BGkUIDeIv4dQYxxlv/iv+uAgw1JKdxFBZWOpPpdxapSP47Az3n 0BDJALgu3OEi568g9YE3JdDvsZa4/P71Xk/2F3LksAMr1Qb8xn1n4Xqj4DPQ9IUms4cX 6aUQ== X-Gm-Message-State: AOAM531vStfrvdZSLAsxqG7j8vF5Y6c+DRDR+9T8Jda7+eHRInTyavUY nrtoLJGZJERRaxq9I1fKOTQ3ig== X-Google-Smtp-Source: ABdhPJxFiTyxBb4nEiwal+GHVSCCZg27kwU0605PJ6wD3sxi9pXqBwPKaneArotjNmoKpZUdxoJztQ== X-Received: by 2002:a17:902:b7c3:b029:da:76bc:2aa9 with SMTP id v3-20020a170902b7c3b02900da76bc2aa9mr7860992plz.21.1610124988722; Fri, 08 Jan 2021 08:56:28 -0800 (PST) Received: from google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) by smtp.gmail.com with ESMTPSA id a19sm8781542pfi.130.2021.01.08.08.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 08:56:27 -0800 (PST) Date: Fri, 8 Jan 2021 08:56:20 -0800 From: Sean Christopherson To: Steve Rutherford Cc: Ashish Kalra , "Dr. David Alan Gilbert" , "Singh, Brijesh" , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Joerg Roedel , Borislav Petkov , "Lendacky, Thomas" , X86 ML , KVM list , LKML , "dovmurik@linux.vnet.ibm.com" , "tobin@ibm.com" , "jejb@linux.ibm.com" , "frankeh@us.ibm.com" , "Grimm, Jon" Subject: Re: [PATCH v2 1/9] KVM: x86: Add AMD SEV specific Hypercall3 Message-ID: References: <20201218193956.GJ2956@work-vm> <20201218195641.GL2956@work-vm> <20210106230555.GA13999@ashkalra_ubuntu_server> <20210107170728.GA16965@ashkalra_ubuntu_server> <20210107184125.GA17388@ashkalra_ubuntu_server> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jan 07, 2021, Steve Rutherford wrote: > Supporting merging of consecutive entries (or not) is less important > to get right since it doesn't change any of the APIs. If someone runs > into performance issues, they can loop back and fix this then. I'm > slightly concerned with the behavior for overlapping regions. I'm assuming merging entries will be a near-trivial effort once everything else is implemented, e.g. KVM will need to traverse the list to remove entries when address are converted back to private. Piling on merging functionality at that point should not be all that hard, especially if the list is sorted and entries are merged on insertion.