From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53955C636D6 for ; Wed, 22 Feb 2023 19:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232728AbjBVT2V (ORCPT ); Wed, 22 Feb 2023 14:28:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232714AbjBVT2T (ORCPT ); Wed, 22 Feb 2023 14:28:19 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0B41199FD for ; Wed, 22 Feb 2023 11:28:18 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-536af109f9aso93370757b3.13 for ; Wed, 22 Feb 2023 11:28:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1ncgyXSBsgJeq7wrxsMy4LqhbZKIDHoclZTNSNLUENI=; b=lPp3P/+jAqBvgQohTYmTDD0TAQQX8vElx+SGA/Fdjpqpgp7X4ZXAkUUWiwp2DNFT3X GqB559DmNdRCk/fizAD3aSPNa9ZdtOrDO1fqiBLbp5FhmgOyzBznOvh2//7F0L0rrTaf ADY3pMXCuIPU6Bwv4GP4ZGhYHCN2PdfHnbWI+dFzcbAtLVrYHjEk7bIS1U9sAoQeEfL5 LK3y/wuYUVlFNRWsnGRbZ0Iq76k0HJ1OG/na75dFBnYikMRq9f1ZA2bHba4++hOCEHqG YxBRwMkxGfkslTEmPOBEhz35wceGoIQttwp0eQlUQDiFj/LwDawGyXUf6BmRdbj6apn4 A54g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1ncgyXSBsgJeq7wrxsMy4LqhbZKIDHoclZTNSNLUENI=; b=hIr8v3S3duk81L/uG29WtTSA3/Nk+hR6L4/u7yAa5fZHXhetc1Fx5qC0JeLongpgou J7WNyiq1duUT7nO6MA7N2hQw44TOht5FwZWXlCl7Ret8GoZ0oxlcpqT+DwLJthLjieR6 vOqKA3OazlCii+YSkpQ4XVmfjqvayZ1KT+Zpl9nzN4ff99IYotbiRxyjbjMUeoMSTWPB w/pJuNDKpzAKD61jtHOrbVNwYtEq5rJHjWwPc4wBkwUGMMSPKpcsAeEYV1xbKGJO8w4N 1nqBTBcSRQXDZAm0+VZ9AaS1ZisDMTmZxzJP5WCW5aEFfBCqnG/awOIajsXVLH/5DPEX TJbg== X-Gm-Message-State: AO0yUKWtlECoPRXymzsAGG+LlQCexi7Rda4SQ/POTvDPLP361PgYMK+K Q3m0VtWUmHWtupssajMueHTwlGCaFZY= X-Google-Smtp-Source: AK7set/migc9eZDF9Jt8DO4SyvFLBdhry2B2rzLsJS06zwAZEaYvIiX2Jf9s9qcrBQhnsS38/zTdxuNH4GA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:df82:0:b0:527:ac6f:625b with SMTP id i124-20020a0ddf82000000b00527ac6f625bmr1330959ywe.431.1677094097863; Wed, 22 Feb 2023 11:28:17 -0800 (PST) Date: Wed, 22 Feb 2023 11:28:16 -0800 In-Reply-To: <20230222082002.97570-1-likexu@tencent.com> Mime-Version: 1.0 References: <20230222082002.97570-1-likexu@tencent.com> Message-ID: Subject: Re: [PATCH] KVM: x86/pmu: Apply event filter mechanism to emulated instructions From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jinrong Liang , Aaron Lewis Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Feb 22, 2023, Like Xu wrote: > From: Like Xu > > The check_pmu_event_filter() prevents the perf_event from being created > and stops the associated counters from increasing, the same check should > also be applied to counter increases caused by emulated instructions. > Otherwise this filter mechanism cannot be considered to be in effect. > > Reported-by: Jinrong Liang Already posted by Aaron[*], but I don't think there's been a follow-up. Aaron? [*] https://lore.kernel.org/all/20221209194957.2774423-2-aaronlewis@google.com