From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8ECC636CC for ; Wed, 15 Feb 2023 22:11:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbjBOWLX (ORCPT ); Wed, 15 Feb 2023 17:11:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjBOWLW (ORCPT ); Wed, 15 Feb 2023 17:11:22 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12CD142DFF for ; Wed, 15 Feb 2023 14:11:21 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id 79-20020a250b52000000b009419f64f6afso35270ybl.2 for ; Wed, 15 Feb 2023 14:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=oudIwnEPPAGRBRrCfLq7ua1hvqy4La4rrkSnZmTBp/0=; b=JCTFc/XD5KHvKUrSaQKv4dzmCop87QijxyX9tGllF1EmLMsNtkfsSpbL5bEwPHeUOm 1W0AucJ3Vw4PiLgErIrY1vjRWlX/0/WOdGveetOzf+XsPm2dGek2Tz4tBfrube1okBem bIX9j6lejcv6kRaVIGGPvTTHNkOe4SprqNdhqJ7m1XWhtPsvLRSrRm4wgqd0fwKJoRhR /0j0sj0irfUMMJjuNvDzHuNkFSV+dylfdM7/JX0PUoW8zt1C0k46H7YBiVbLE0ynLqG8 NfNOHPZDkR80w/hvTm8S7cH5LMrlgeasn+fA+3ym8uu4AJit4sKoKk5x6czlO6oG4EnE Ihpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oudIwnEPPAGRBRrCfLq7ua1hvqy4La4rrkSnZmTBp/0=; b=6JCTsuUqTv70rFhZqUh1UmxL+FcZyO+Kcu9ViPU+33p070FXkVzdVRRVUmKadwlNjj qedcvSCdv/1jrZJMTwXNbHZ1qsLEUefhIgmUBwW8X8itcSbL2GM9uAvNQX2Q9ShoSwdf bCDZcaWlm6Gq0QFXlJyj+OQxxY1A++Nmsa/h/U72TmNz4tTdutnwtTMSx0CKNL0od7Cu veyY0ZqBK/NJ7LOUoWpKpN3IJItGQqgiXd5N06oFkmwPvJvOhDPfPJtjiTyQVFfWBVG3 eoxOx4HChWxqe9XPba/zcFldcJ4zYE70wjnNte1qaQBilD77zHffSI+rPaEC7DGUey+E XNbw== X-Gm-Message-State: AO0yUKWsV7pTX4A0PYnc4eXjf0wdTI+6EMOAi25a28LQV+6ASjLCDbr3 1Rr2PtisiKzVxP8fcDOY916p6Gam3zM= X-Google-Smtp-Source: AK7set9syMGwwbPlXmBc/5glGE+EpC18KxAdh4RUvLmWB8+O0XSG5n+IUtEl9uk0lbMxdt5l4FX6JvCAe2A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:205:b0:8e9:abfc:1a38 with SMTP id j5-20020a056902020500b008e9abfc1a38mr12ybs.10.1676499079682; Wed, 15 Feb 2023 14:11:19 -0800 (PST) Date: Wed, 15 Feb 2023 14:11:17 -0800 In-Reply-To: Mime-Version: 1.0 References: <20230207002156.521736-1-seanjc@google.com> Message-ID: Subject: Re: [PATCH v2 0/3] KVM: SVM: Fix GATag bug for >256 vCPUs From: Sean Christopherson To: Suravee Suthikulpanit Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alejandro Jimenez Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Feb 16, 2023, Suthikulpanit, Suravee wrote: > > > On 2/7/2023 7:21 AM, Sean Christopherson wrote: > > Fix a bug in KVM's use of the GATag where it unintentionally drops a bit > > from vCPU IDs greater than 255 and as a result wakes the wrong vCPU. > > > > Suravee and/or Alejandro, can you give this proper testing? It's compile > > tested only at this point. I'll do basic testing before officially > > applying, but AFAIK I don't have access to x2AVIC hardware, nor do I have > > a ready-to-go configuration to properly exercise this code. > > > > Thanks! > > > > Sean Christopherson (2): > > KVM: SVM: Fix a benign off-by-one bug in AVIC physical table mask > > KVM: SVM: WARN if GATag generation drops VM or vCPU ID information > > > > Suravee Suthikulpanit (1): > > KVM: SVM: Modify AVIC GATag to support max number of 512 vCPUs > > > > arch/x86/include/asm/svm.h | 12 +++++++----- > > arch/x86/kvm/svm/avic.c | 37 ++++++++++++++++++++++++++++--------- > > 2 files changed, 35 insertions(+), 14 deletions(-) > > > > > > base-commit: 32e69f232db4ca11f26e5961daeff93906ce232f > > For the series: > > Tested-by: Suravee Suthikulpanit Thanks much! Paolo, do you want to grab this directly, or should I throw this in next for a few days and send a separate pull request? Or do something else entirely?