[PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static

[PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static

[David Matlack]

Make @tdp_mmu_allowed static since it is only ever used within
arch/x86/kvm/mmu/mmu.c.

Link: https://lore.kernel.org/kvm/202302072055.odjDVd5V-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: David Matlack <dmatlack@google.com>
---
 arch/x86/kvm/mmu/mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index aeb240b339f5..adb9438be3ca 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -100,7 +100,7 @@ module_param_named(flush_on_reuse, force_flush_and_sync_on_reuse, bool, 0644);
  */
 bool tdp_enabled = false;
 
-bool __ro_after_init tdp_mmu_allowed;
+static bool __ro_after_init tdp_mmu_allowed;
 
 #ifdef CONFIG_X86_64
 bool __read_mostly tdp_mmu_enabled = true;

base-commit: f15a87c006901e02727bf8ac75b0251cdf8e0ecc
-- 
2.39.1.581.gbfd45094c4-goog

Re: [PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static

[Sean Christopherson]

On Mon, Feb 13, 2023, David Matlack wrote:
> Make @tdp_mmu_allowed static since it is only ever used within

Doesn't "@" usually refer to function parameters?

> arch/x86/kvm/mmu/mmu.c.
> 
> Link: https://lore.kernel.org/kvm/202302072055.odjDVd5V-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: David Matlack <dmatlack@google.com>
> ---

Fixes: 3af15ff47c4d ("KVM: x86/mmu: Change tdp_mmu to a read-only parameter")
Reviewed-by: Sean Christopherson <seanjc@google.com>

Paolo, want to grab this one directly for 6.3?

Re: [PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static

[David Matlack]

On Wed, Feb 15, 2023 at 4:44 PM Sean Christopherson <seanjc@google.com> wrote:
>
> On Mon, Feb 13, 2023, David Matlack wrote:
> > Make @tdp_mmu_allowed static since it is only ever used within
>
> Doesn't "@" usually refer to function parameters?

Oh is that the convention? For some reason I assumed it was used when
referring to any variable.

>
> > arch/x86/kvm/mmu/mmu.c.
> >
> > Link: https://lore.kernel.org/kvm/202302072055.odjDVd5V-lkp@intel.com/
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: David Matlack <dmatlack@google.com>
> > ---
>
> Fixes: 3af15ff47c4d ("KVM: x86/mmu: Change tdp_mmu to a read-only parameter")
> Reviewed-by: Sean Christopherson <seanjc@google.com>
>
> Paolo, want to grab this one directly for 6.3?

Re: [PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static

[Sean Christopherson]

On Wed, Feb 15, 2023, David Matlack wrote:
> On Wed, Feb 15, 2023 at 4:44 PM Sean Christopherson <seanjc@google.com> wrote:
> >
> > On Mon, Feb 13, 2023, David Matlack wrote:
> > > Make @tdp_mmu_allowed static since it is only ever used within
> >
> > Doesn't "@" usually refer to function parameters?
> 
> Oh is that the convention? For some reason I assumed it was used when
> referring to any variable.

Yes?  My experience with it is entirely in the context of kernel-doc syntax, where
it's used to document function params and struct field.  Global symbols don't
need additional reference because they are the focus of the comment/documentation.

Re: [PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static

[Paolo Bonzini]

On 2/16/23 01:44, Sean Christopherson wrote:
> Paolo, want to grab this one directly for 6.3?
Yep, done (and removed the "@").

Paolo