From: Sean Christopherson <seanjc@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: Anish Moorthy <amoorthy@google.com>,
pbonzini@redhat.com, kvm@vger.kernel.org, jthoughton@google.com
Subject: Re: [PATCH] selftests/kvm: Fix bug in how demand_paging_test calculates paging rate
Date: Thu, 16 Feb 2023 12:17:31 -0800 [thread overview]
Message-ID: <Y+6PWxGL5w+pwbhe@google.com> (raw)
In-Reply-To: <Y+6OVtw1kEO99Gah@linux.dev>
On Thu, Feb 16, 2023, Oliver Upton wrote:
> The shortlog doesn't give any hint as to what the bug actually is.
> Maybe:
>
> KVM: selftests: Fix nsec to sec conversion in demand_paging_test
+1
> On Thu, Feb 16, 2023 at 08:02:18PM +0000, Anish Moorthy wrote:
> > The current denominator is 1E8, not 1E9 as it should be.
>
> demand_paging_test uses 1E8 as the denominator to convert nanoseconds
> to seconds, which is wrong. Use NSEC_PER_SEC instead to fix the issue
> and make the conversion obvious.
>
> > Reported-by: James Houghton <jthoughton@google.com>
> > Signed-off-by: Anish Moorthy <amoorthy@google.com>
>
> Bikeshedding aside:
>
> Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
With Oliver's shortlog (I'm indifferent on the changelog),
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2023-02-16 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 20:02 [PATCH] selftests/kvm: Fix bug in how demand_paging_test calculates paging rate Anish Moorthy
2023-02-16 20:13 ` Oliver Upton
2023-02-16 20:17 ` Sean Christopherson [this message]
2023-02-16 20:24 ` [PATCH] selftests/kvm: Fix nsec to sec conversion in demand_paging_test Anish Moorthy
2023-02-16 20:33 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+6PWxGL5w+pwbhe@google.com \
--to=seanjc@google.com \
--cc=amoorthy@google.com \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).