From: David Matlack <dmatlack@google.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: seanjc@google.com, pbonzini@redhat.com, bgardon@google.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2 4/5] KVM: x86/mmu: Remove handle_changed_spte_dirty_log()
Date: Mon, 6 Feb 2023 15:59:14 -0800 [thread overview]
Message-ID: <Y+GUUr/UE0V0WsrR@google.com> (raw)
In-Reply-To: <20230203192822.106773-5-vipinsh@google.com>
On Fri, Feb 03, 2023 at 11:28:21AM -0800, Vipin Sharma wrote:
> Remove handle_changed_spte_dirty_log() as there is no code flow which
> sets leaf SPTE writable and hit this path.
Heh, way too vague again. e.g. This needs to explain how make_spte()
marks pages are dirty when constructing new SPTEs for the TDP MMU.
next prev parent reply other threads:[~2023-02-06 23:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 19:28 [Patch v2 0/5] Optimize clear dirty log Vipin Sharma
2023-02-03 19:28 ` [Patch v2 1/5] KVM: x86/mmu: Make separate function to check for SPTEs atomic write conditions Vipin Sharma
2023-02-06 22:09 ` Ben Gardon
2023-02-06 23:17 ` David Matlack
2023-02-03 19:28 ` [Patch v2 2/5] KVM: x86/mmu: Optimize SPTE change flow for clear-dirty-log Vipin Sharma
2023-02-06 22:06 ` Ben Gardon
2023-02-06 23:34 ` David Matlack
2023-02-07 17:29 ` Vipin Sharma
2023-02-06 23:41 ` David Matlack
2023-02-07 17:36 ` Vipin Sharma
2023-02-07 17:47 ` David Matlack
2023-02-08 23:44 ` Vipin Sharma
2023-02-06 23:53 ` David Matlack
2023-02-07 17:41 ` Vipin Sharma
2023-02-03 19:28 ` [Patch v2 3/5] KVM: x86/mmu: Optimize SPTE change for aging gfn range Vipin Sharma
2023-02-06 22:17 ` Ben Gardon
2023-02-07 17:48 ` Vipin Sharma
2023-02-06 23:56 ` David Matlack
2023-02-07 17:50 ` Vipin Sharma
2023-02-03 19:28 ` [Patch v2 4/5] KVM: x86/mmu: Remove handle_changed_spte_dirty_log() Vipin Sharma
2023-02-06 23:59 ` David Matlack [this message]
2023-02-07 17:51 ` Vipin Sharma
2023-02-03 19:28 ` [Patch v2 5/5] KVM: x86/mmu: Merge all handle_changed_pte* functions Vipin Sharma
2023-02-06 22:33 ` Ben Gardon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+GUUr/UE0V0WsrR@google.com \
--to=dmatlack@google.com \
--cc=bgardon@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).