From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6100AC636CC for ; Wed, 8 Feb 2023 14:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231586AbjBHOtG (ORCPT ); Wed, 8 Feb 2023 09:49:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231567AbjBHOtD (ORCPT ); Wed, 8 Feb 2023 09:49:03 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4784ABD3 for ; Wed, 8 Feb 2023 06:48:56 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id g13so14699556ple.10 for ; Wed, 08 Feb 2023 06:48:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FFBEpHVyO7uaEXohEkZMXZFRiWaMnYer0SJSyNE2OQo=; b=hMOdPggyeGwA8nIQGyI3lk8r6madEiHE1tfQILTzxCiy1S7kUMUVaOhyHsVp06goap xu3OTi4hYwWjZUQvyadbZEP3tCnJkNTADf3pcXG10U3Bg6jMDXlkGMHqGqVwwoskxqZD tawgXU9UGZ0cqOWkVEH3kiqEmuD8kla7MXmbwv9628VLynYNqSAJDTBK375CkOiEJXju sdjTjOye77/aoufgQyQHZ+ZVVxHUrUPnqxX8duSqU938FVPItqp/CwL5e/cVkwmZk/MT owWkEI8ueZFmAdHcW1jyYhtr52ME/ScfkE4iQ6i34E9szGx+u+4lnFOthBjNQywWGZ1M jM5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FFBEpHVyO7uaEXohEkZMXZFRiWaMnYer0SJSyNE2OQo=; b=QKG5lmghZnPB+Aw9kwKLUjHYbjCeerWFL9awEgyU0uDjGl8BBAq24/OGcDZjRFFiaz biFBuw3wplw2mFiKL8FsKPxHcP+NkdGcB9rFa2etiTgd+FJs3SB4aLKTOjYJd/kW5WHT fr3eG9H2oLEXzNJtVX1o9mBPjLeNQBEIvykAnvgQse29Q4ylOynmshrEacUQsBrT9U1N d4E2BCJptEZO1x9XHu2WK09lZrwNdouiMjYCMfzI5dyQIrvMS5+bRoYNL56me1LehN4N GzqtIf2BzlaA6TW9KrNbkBAUzuH6Jx9U3g+6Y5b+E3FaPsAGEIvG7CgJ+IWLsaW5WaTq gjdQ== X-Gm-Message-State: AO0yUKVtk2Y/fSqvMrIpiJkdhfeMvJtcX+5EV+NrbjTQhZQ+mgczfATp Y9HEuZeszRmrRG8e2C/VA6IO4w== X-Google-Smtp-Source: AK7set+p35lGTvN8xsFLL4fqhMTQyitTRsLEsTPZ+gHzxMmxq7tY2+fV/RaR4t2O3sr/KKtToUrGwQ== X-Received: by 2002:a17:902:e74e:b0:198:af50:e4e9 with SMTP id p14-20020a170902e74e00b00198af50e4e9mr240153plf.15.1675867735657; Wed, 08 Feb 2023 06:48:55 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l2-20020a170902ec0200b00199019e247csm7680677pld.207.2023.02.08.06.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 06:48:55 -0800 (PST) Date: Wed, 8 Feb 2023 14:48:51 +0000 From: Sean Christopherson To: Thomas Huth Cc: kvm@vger.kernel.org, Paolo Bonzini , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm-riscv@lists.infradead.org, Marc Zyngier , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Christian Borntraeger , Janosch Frank , David Hildenbrand , Gavin Shan , Steven Price , Cornelia Huck Subject: Re: [PATCH v2 3/6] KVM: x86: Remove the KVM_GET_NR_MMU_PAGES ioctl Message-ID: References: <20230208140105.655814-1-thuth@redhat.com> <20230208140105.655814-4-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230208140105.655814-4-thuth@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Feb 08, 2023, Thomas Huth wrote: > The KVM_GET_NR_MMU_PAGES ioctl is quite questionable on 64-bit hosts > since it fails to return the full 64 bits of the value that can be > set with the corresponding KVM_SET_NR_MMU_PAGES call. Its "long" return > value is truncated into an "int" in the kvm_arch_vm_ioctl() function. > > Since this ioctl also never has been used by userspace applications > (QEMU, Google's internal VMM, kvmtool and CrosVM have been checked), > it's likely the best if we remove this badly designed ioctl before > anybody really tries to use it. > > Signed-off-by: Thomas Huth > --- Reviewed-by: Sean Christopherson