From: Jason Gunthorpe <jgg@nvidia.com>
To: chenxiang <chenxiang66@hisilicon.com>
Cc: alex.williamson@redhat.com, cohuck@redhat.com,
kvm@vger.kernel.org, baolu.lu@linux.intel.com,
kevin.tian@intel.com, linuxarm@huawei.com
Subject: Re: [PATCH] [PATCH] Revert 'vfio: Delete container_q'
Date: Mon, 10 Oct 2022 15:27:56 -0300 [thread overview]
Message-ID: <Y0RkLBiZc6RWl3pB@nvidia.com> (raw)
In-Reply-To: <1665222631-202970-1-git-send-email-chenxiang66@hisilicon.com>
On Sat, Oct 08, 2022 at 05:50:31PM +0800, chenxiang wrote:
> From: Xiang Chen <chenxiang66@hisilicon.com>
>
> We find a issue on ARM64 platform with HNS3 VF SRIOV enabled (VFIO
> passthrough in qemu):
> kill the qemu thread, then echo 0 > sriov_numvfs to disable sriov
> immediately, sometimes we will see following warnings:
I suspect this is fixed in vfio-next now, in a different way. Please check
> After removing container_q, arm_smmu_release_dev() caused by disabling
> sriov may occur before arm_smmuv3_attach_dev() called by echo 0 > sriov_numvfs,
> and arm_smmu_attach_dev() may refer to freed iommu_fwspec, so it causes
> above warnings.
Which is the same effective issue s390 hit already.
It is interesting that container_q was solving this, that seems to be
a inadverent side effect nobody noticed.
Jason
next prev parent reply other threads:[~2022-10-10 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 9:50 [PATCH] [PATCH] Revert 'vfio: Delete container_q' chenxiang
2022-10-10 18:27 ` Jason Gunthorpe [this message]
2022-10-11 2:30 ` chenxiang (M)
2022-10-11 2:49 ` Tian, Kevin
2022-10-14 1:18 ` chenxiang (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0RkLBiZc6RWl3pB@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=cohuck@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox