From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2 4/4] vfio: Fold vfio_virqfd.ko into vfio.ko
Date: Tue, 11 Oct 2022 13:40:24 -0300 [thread overview]
Message-ID: <Y0WceKm7xzJZprtP@nvidia.com> (raw)
In-Reply-To: <Y0PF/fcZ/6gzy1JL@infradead.org>
On Mon, Oct 10, 2022 at 12:13:01AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 03, 2022 at 12:39:33PM -0300, Jason Gunthorpe wrote:
> > This is only 1.8k, putting it in its own module is going to waste more
> > space rounding up to a PAGE_SIZE than it is worth. Put it in the main
> > vfio.ko module now that kbuild can support multiple .c files.
>
> Assuming you actually need it (only vfio_platform and vfio_pci actually
> need it) and you don't otherwise need EVENTFD support. While I guess
> the configfs that do not fit the above aren't the most common they
> are real and are a real tradeoff.
Well, the config still exists, if someone is building a stripped down
kernel they can disable it and save the space. By the time you fully
load VFIO this is just noise. I don't have a specific preference here,
but I would like to reduce the number of modules just for sanity's
sake.
Jason
prev parent reply other threads:[~2022-10-11 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 15:39 [PATCH v2 0/4] Simplify the module and kconfig structure in vfio Jason Gunthorpe
2022-10-03 15:39 ` [PATCH v2 1/4] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko Jason Gunthorpe
2022-10-10 7:07 ` Christoph Hellwig
2022-10-10 18:32 ` Jason Gunthorpe
2022-10-11 6:30 ` Christoph Hellwig
2022-10-03 15:39 ` [PATCH v2 2/4] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c Jason Gunthorpe
2022-10-10 7:09 ` Christoph Hellwig
2022-10-10 18:42 ` Jason Gunthorpe
2022-10-11 6:31 ` Christoph Hellwig
2022-10-03 15:39 ` [PATCH v2 3/4] vfio: Remove CONFIG_VFIO_SPAPR_EEH Jason Gunthorpe
2022-10-03 15:39 ` [PATCH v2 4/4] vfio: Fold vfio_virqfd.ko into vfio.ko Jason Gunthorpe
2022-10-05 16:37 ` Cornelia Huck
2022-10-05 16:53 ` Jason Gunthorpe
2022-10-10 7:13 ` Christoph Hellwig
2022-10-11 16:40 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0WceKm7xzJZprtP@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox