From: Sean Christopherson <seanjc@google.com>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bilbao@vt.edu
Subject: Re: [PATCH] KVM: SEV: Fix a few small typos
Date: Tue, 11 Oct 2022 19:45:06 +0000 [thread overview]
Message-ID: <Y0XHwmNDJj68pKp5@google.com> (raw)
In-Reply-To: <515927f6-a53e-519e-6d7b-80f26f6f8946@amd.com>
On Tue, Oct 11, 2022, Carlos Bilbao wrote:
> On 10/11/22 13:51, Sean Christopherson wrote:
>
> > On Wed, Sep 28, 2022, Carlos Bilbao wrote:
> > > @@ -3510,7 +3510,7 @@ bool sev_snp_init_protected_guest_state(struct kvm_vcpu *vcpu)
> > > ret = __sev_snp_update_protected_guest_state(vcpu);
> > > if (ret)
> > > - vcpu_unimpl(vcpu, "snp: AP state update on init failed\n");
> > > + vcpu_unimpl(vcpu, "SNP: AP state update on init failed\n");
> > > unlock:
> > > mutex_unlock(&svm->snp_vmsa_mutex);
> > > @@ -4170,7 +4170,7 @@ void sev_es_prepare_guest_switch(struct vcpu_svm *svm, unsigned int cpu)
> > > /* PKRU is restored on VMEXIT, save the current host value */
> > > hostsa->pkru = read_pkru();
> > > - /* MSR_IA32_XSS is restored on VMEXIT, save the currnet host value */
> > > + /* MSR_IA32_XSS is restored on VMEXIT, save the current host value */
> > > hostsa->xss = host_xss;
> > > }
> > > @@ -4223,7 +4223,7 @@ struct page *snp_safe_alloc_page(struct kvm_vcpu *vcpu)
> > > * Allocate an SNP safe page to workaround the SNP erratum where
> > > * the CPU will incorrectly signal an RMP violation #PF if a
> > > * hugepage (2mb or 1gb) collides with the RMP entry of VMCB, VMSA
> > > - * or AVIC backing page. The recommeded workaround is to not use the
> > > + * or AVIC backing page. The recommended workaround is to not use the
> > > * hugepage.
> > > *
> > > * Allocate one extra page, use a page which is not 2mb aligned
> > SNP support doesn't exist upstream, looks like this was generated against an SNP
> > branch.
> You're absolutely right. The only typo that's upstream is "currnet" in
> sev_es_prepare_switch_to_guest(). Not a big deal.
Ya, and that typo should (eventually) go away entirely:
https://lore.kernel.org/all/YzOTOzUzKPQSqURo@google.com
prev parent reply other threads:[~2022-10-11 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 17:31 [PATCH] KVM: SEV: Fix a few small typos Carlos Bilbao
2022-10-11 18:51 ` Sean Christopherson
2022-10-11 19:22 ` Carlos Bilbao
2022-10-11 19:45 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0XHwmNDJj68pKp5@google.com \
--to=seanjc@google.com \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox