Re: [kvm-unit-tests PATCH v1] x86: efi: set up the IDT before accessing MSRs.

[Vasant Karasulli <vkarasulli@suse.de>]

Hi Sean,

> Reviewed-by: Sean Christopherson <seanjc@google.com>
>
> >  lib/x86/setup.c | 20 ++++++++++++--------
> >  1 file changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/lib/x86/setup.c b/lib/x86/setup.c
> > index 7df0256..712e292 100644
> > --- a/lib/x86/setup.c
> > +++ b/lib/x86/setup.c
> > @@ -192,8 +192,6 @@ static void setup_segments64(void)
> >  	write_gs(KERNEL_DS);
> >  	write_ss(KERNEL_DS);
> >
> > -	/* Setup percpu base */
> > -	wrmsr(MSR_GS_BASE, (u64)&__percpu_data[pre_boot_apic_id()]);
> >
> >  	/*
> >  	 * Update the code segment by putting it on the stack before the return
> > @@ -322,7 +320,7 @@ efi_status_t setup_efi(efi_bootinfo_t *efi_bootinfo)
> >  		}
> >  		return status;
> >  	}
> > -
> > +
>
> Huh.  This causes a conflict for me.  My local repo has a tab here that is
> presumably being removed, but this patch doesn't have anything.  If I manually
> add back the tab, all is well.  I suspect your client may be stripping trailing
> whitespace.

Yes, I think my client was stripping trailing whitespaces. Do you want me
to send a new version of the patch with that formatting?


Thanks,
Vasant Karasulli
Kernel generalist
www.suse.com<http://www.suse.com>
[https://www.suse.com/assets/img/social-platforms-suse-logo.png]<http://www.suse.com/>
SUSE - Open Source Solutions for Enterprise Servers & Cloud<http://www.suse.com/>
Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage.
www.suse.com