From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D77AC4332F for ; Thu, 13 Oct 2022 13:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbiJMNk4 (ORCPT ); Thu, 13 Oct 2022 09:40:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbiJMNku (ORCPT ); Thu, 13 Oct 2022 09:40:50 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25D4241D0C for ; Thu, 13 Oct 2022 06:40:47 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5FF631F86B; Thu, 13 Oct 2022 13:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1665668445; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wS3vvMJ4U4WZC5hNyYycWQun9eb3ZjLXirkyOzT8smo=; b=T3UjOw+TbNIoVwLRPF792XdWNimig+cZWUKgZYzwq1/ty9Cx5hOss9ej7XVH0rRrMEIWiz ZF58V/NG5J9PUDr9deXaHeI1aygqUBywIeJw3se71i45M7LAAUHvEZMRYq8NAeAqAa6axL vFKMhdx2X4HUHiGVyO/k9PWpxx2+CXs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1665668445; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wS3vvMJ4U4WZC5hNyYycWQun9eb3ZjLXirkyOzT8smo=; b=3ey6RJOSmUFHzQK7iyVW+6r6N+A9VMv+0Vg9yF+rgEiy7aiVm3AIV8++xQSLzWB3UuEFoK PMs8HBPqzkn6wgCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2587113AAA; Thu, 13 Oct 2022 13:40:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K96hBV0VSGMUPAAAMHmgww (envelope-from ); Thu, 13 Oct 2022 13:40:45 +0000 Date: Thu, 13 Oct 2022 15:40:43 +0200 From: Vasant Karasulli To: Sean Christopherson Cc: kvm@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH v1] x86: efi: set up the IDT before accessing MSRs. Message-ID: References: <20220823094328.8458-1-vkarasulli@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Sean, > Reviewed-by: Sean Christopherson > > > lib/x86/setup.c | 20 ++++++++++++-------- > > 1 file changed, 12 insertions(+), 8 deletions(-) > > > > diff --git a/lib/x86/setup.c b/lib/x86/setup.c > > index 7df0256..712e292 100644 > > --- a/lib/x86/setup.c > > +++ b/lib/x86/setup.c > > @@ -192,8 +192,6 @@ static void setup_segments64(void) > > write_gs(KERNEL_DS); > > write_ss(KERNEL_DS); > > > > - /* Setup percpu base */ > > - wrmsr(MSR_GS_BASE, (u64)&__percpu_data[pre_boot_apic_id()]); > > > > /* > > * Update the code segment by putting it on the stack before the return > > @@ -322,7 +320,7 @@ efi_status_t setup_efi(efi_bootinfo_t *efi_bootinfo) > > } > > return status; > > } > > - > > + > > Huh. This causes a conflict for me. My local repo has a tab here that is > presumably being removed, but this patch doesn't have anything. If I manually > add back the tab, all is well. I suspect your client may be stripping trailing > whitespace. Yes, I think my client was stripping trailing whitespaces. Do you want me to send a new version of the patch with that formatting? Thanks, Vasant Karasulli Kernel generalist www.suse.com [https://www.suse.com/assets/img/social-platforms-suse-logo.png] SUSE - Open Source Solutions for Enterprise Servers & Cloud Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage. www.suse.com