From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBEC0C433FE for ; Wed, 19 Oct 2022 22:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbiJSWWQ (ORCPT ); Wed, 19 Oct 2022 18:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229936AbiJSWWO (ORCPT ); Wed, 19 Oct 2022 18:22:14 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 221D417653E for ; Wed, 19 Oct 2022 15:22:13 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id a5-20020a17090aa50500b002008eeb040eso1716079pjq.1 for ; Wed, 19 Oct 2022 15:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lc7nEof8oNxTjR2TgiwAPvjHm//OCLDZ/hnb6eCYs60=; b=HGPCbZUrDHdBVHRaWY50SoPN04wgSXoiM3jyszD7bVxUzze4tlx2F2sEVU085BI8Xn YAsH3vRWZYDL5RUk3DL9pct18PeCzjEVQqY077njbVmzDUB5xjiBbLSaj6ZE0zTPSjM4 8wYiNckByKH6HeJt6NMq/UlI8+78sxyCHJ9cDQ+ctOTzCQzztPMG03CIIQLP2YJHSr2N uFddX8aDHiUcPAw70YswY/qpyneHOfIQ4fj96yXq8PChcxG+yI3ZpNgsht4PHA+LFexQ waXhyXT4ox1DxWQa6U8mDXmZNfaXfn92TtdDe1q+KuzJWwaex1I+w+ohIp7wB/EwzLDf xOgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lc7nEof8oNxTjR2TgiwAPvjHm//OCLDZ/hnb6eCYs60=; b=Q6zHyaB42SvV+xMugv+lp2Qs5CGOX76E5BhdfklLf5Dq8x7PhnTK0pyhOCtp8p57EX zmtsD/Ce4BrbktIR0XwDidD0ATlK4OKWBnn5yKKNwmLyRt9K5y5BfQ3tZdTPO+gLlYHL 6J7m2204F+qKXGb5TH+tnmjhdSkEwdrXmhpuUb4x+n45A30S0D4xh8BAwHK+dbsi7xZw bpW22TL8GJnwBrLqOTirW/syZBw0YMhulu/YHuvwlwIdYfFi2veODF3OWa8W3oKrWoGv PFB1pxTCBR+NUY4+WhW2gXe850sdYpRXtBFdKu/PTY1eBh1gD0aCwxWea/16pZk8PB20 KUwA== X-Gm-Message-State: ACrzQf0ZeXRc7kxstux9as6FHEuTHrK/br9svbCFxFQQjLn4iaN9K/dL LiGj/QmuZvcyJdt8xZuVA2CeSA== X-Google-Smtp-Source: AMsMyM4nva1F0shlU4yDMbuqeLmJzlH65ES6wwFswJNL+VYstN5urGF/pcqOEtXB/lEYdDqw71Tp6w== X-Received: by 2002:a17:90b:314c:b0:20d:83c1:5297 with SMTP id ip12-20020a17090b314c00b0020d83c15297mr12147095pjb.18.1666218132524; Wed, 19 Oct 2022 15:22:12 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id c11-20020a624e0b000000b0056170e7299csm11762357pfb.9.2022.10.19.15.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 15:22:12 -0700 (PDT) Date: Wed, 19 Oct 2022 22:22:08 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , Yuan Yao , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 00/46] KVM: x86: hyper-v: Fine-grained TLB flush + L2 TLB flush features Message-ID: References: <20221004123956.188909-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221004123956.188909-1-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Oct 04, 2022, Vitaly Kuznetsov wrote: > Changes since v10 (Sean): > - New patches added: > - "x86/hyperv: Move VMCB enlightenment definitions to hyperv-tlfs.h" > - "KVM: selftests: Move "struct hv_enlightenments" to x86_64/svm.h" > - "KVM: SVM: Add a proper field for Hyper-V VMCB enlightenments" > - 'x86/hyperv: KVM: Rename "hv_enlightenments" to "hv_vmcb_enlightenments"' > - 'KVM: VMX: Rename "vmx/evmcs.{ch}" to "vmx/hyperv.{ch}"' > - "KVM: x86: Move clearing of TLB_FLUSH_CURRENT to kvm_vcpu_flush_tlb_all()" > - "KVM: selftests: Drop helpers to read/write page table entries" > - "KVM: x86: Make kvm_hv_get_assist_page() return 0/-errno" > - Removed patches: > - "KVM: selftests: Export _vm_get_page_table_entry()" > - Main differences: > - Move Hyper-V TLB flushing out of kvm_service_local_tlb_flush_requests(). > On SVM, Hyper-V TLB flush FIFO is emptied from svm_flush_tlb_current() > - Don't disable IRQs in hv_tlb_flush_enqueue(). > - Don't call kvm_vcpu_flush_tlb_guest() from kvm_hv_vcpu_flush_tlb() but > return -errno instead. > - Avoid unneded flushes in !EPT/!NPT cases. > - Optimize hv_is_vp_in_sparse_set(). > - Move TLFS definitions to asm/hyperv-tlfs.h. > - Use u64 vals in Hyper-V PV TLB flush selftest + multiple smaler changes > - Typos, indentation, renames, ... Some nits throughout, but nothing major. Everything could be fixed up when applying, but if it's not too much trouble I'd prefer a v11, the potential changes to kvm_hv_hypercall_complete() aren't completely trivial.