From: Sean Christopherson <seanjc@google.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix the initial value of mcg_cap
Date: Thu, 20 Oct 2022 14:27:01 +0000 [thread overview]
Message-ID: <Y1FatU6Yf9n5pWB+@google.com> (raw)
In-Reply-To: <20221020031615.890400-1-xiaoyao.li@intel.com>
On Thu, Oct 20, 2022, Xiaoyao Li wrote:
> vcpu->arch.mcg_cap represents the value of MSR_IA32_MCG_CAP. It's
> set via ioctl(KVM_X86_SETUP_MCE) from userspace when exposing and
> configuring MCE to guest.
>
> It's wrong to leave the default value as KVM_MAX_MCE_BANKS.
Why? I agree it's an odd default, but the whole MCE API is odd. Functionally,
I don't see anything that's broken by allowing the guest to access the MCx_CTL MSRs
by default.
next prev parent reply other threads:[~2022-10-20 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 3:16 [PATCH] KVM: x86: Fix the initial value of mcg_cap Xiaoyao Li
2022-10-20 14:27 ` Sean Christopherson [this message]
2022-10-20 15:07 ` Xiaoyao Li
2022-10-20 16:32 ` Sean Christopherson
2022-10-21 3:12 ` Xiaoyao Li
2022-10-21 18:35 ` Sean Christopherson
2022-10-24 1:37 ` Xiaoyao Li
2022-10-25 16:22 ` Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1FatU6Yf9n5pWB+@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox