Re: [PATCH RFC v2 03/13] iommufd: File descriptor, context, kconfig and makefiles

Jason Gunthorpe
2022-09-09T18:47:00Z

On Sun, Sep 04, 2022 at 04:19:04PM +0800, Baolu Lu wrote:
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 589517372408ca..abd041f5e00f4c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10609,6 +10609,16 @@ L: linux-mips@vger.kernel.org
> > S: Maintained
> > F: drivers/net/ethernet/sgi/ioc3-eth.c
> > +IOMMU FD
> > +M: Jason Gunthorpe <jgg@nvidia.com>
> > +M: Kevin Tian <kevin.tian@intel.com>
> > +L: iommu@lists.linux-foundation.org
>
> This mailing list has already been replaced with iommu@lists.linux.dev.

It is also not sorted.. I fixed both

> > +/**
> > + * iommufd_put_object_keep_user() - Release part of the refcount on obj
> > + * @obj - Object to release
> > + *
> > + * Objects have two protections to ensure that userspace has a consistent
> > + * experience with destruction. Normally objects are locked so that destroy will
> > + * block while there are concurrent users, and wait for the object to be
> > + * unlocked.
> > + *
> > + * However, destroy can also be blocked by holding users reference counts on the
> > + * objects, in that case destroy will immediately return EBUSY and will not wait
> > + * for reference counts to go to zero.
> > + *
> > + * This function releases the destroy lock and destroy will return EBUSY.
>
> This reads odd. Does it release or acquire a destroy lock.

I changed this line to
This function switches from blocking userspace to returning EBUSY.

And the rest too, thanks

Jason