From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF855C433FE for ; Thu, 27 Oct 2022 00:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233986AbiJ0AQT (ORCPT ); Wed, 26 Oct 2022 20:16:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233766AbiJ0AQS (ORCPT ); Wed, 26 Oct 2022 20:16:18 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8185FC00 for ; Wed, 26 Oct 2022 17:16:17 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id f9so12287886pgj.2 for ; Wed, 26 Oct 2022 17:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z7vXj+46fyiPuMGxxnyzn51Lo7cwsHpHRS0ZMf50pys=; b=QXw2HkHNc0iKGWFmi7Z2IQcr2gcKU2aX4UtOMqDNsYx0fjh/LLxbtbZqQ7tT7x2WBv rDCEt/q9zAfZhebZR2epjwFdZe2BCBOK5vJR0EHGdJPL778Kgp+wDPtoNllEqWSUlR+b 4TTRxXgQQFRtjszSFec2jRhDwGKahlOOy46kG/VRmbgmj5PaFTpDZbbO6pWJ25xt8e1i u52GJGZ85CugzxrHntkp2URS2xyp2h0SqGNAjib0g7xqqY+x++cYWRnR13DASBISv3wG H+4AWkrcMoVjgP+myBECLSQD1wDPFmIJvFvDtR+GlJnht7EaYEy7uTw+TkjDq7YsV/k3 uZGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z7vXj+46fyiPuMGxxnyzn51Lo7cwsHpHRS0ZMf50pys=; b=cqFhGS+Eup/8Xsp0SJCa9+3R/5gypPuRuvB+5ehSmRc+dxC6vEaoj9ToZzeiXrLMCx Uy03w4I5dEcXxdyJgT3bEgLqHK5MfTr00ifrp4xAIeqJqWycXT5+06yhy0uks4MGOfVN 2Ly2NCZkFDZPyd9oZgZbW/5rpmSb6TFP1Zyofr5M+a9JBHSbDdvZSwZ66XDOrFPGQiy+ h9DIKsNFa1UWvADX+CPYbXdqzSYdYtNmjcA+hwBef/v7oHV4WFP5+sE7Q8zaqquvVCsc uor4H6du+4ophTddjyhwwVWohQSiB51L0CxXxlMrZd+k2mrhCa3ObLNjF7lmXW654Fkr cx3g== X-Gm-Message-State: ACrzQf3s7eSAgMt8O/CfQ5EXoVhvttcGY36/XZpTtY52mtx2bTBcf+PC 7jKOLrbpuGMcD82W9kM77ja7uA== X-Google-Smtp-Source: AMsMyM58wWW0puBkcWpp/B6QRCuzQ6np8ztWs4unLkweQabmDbjHTA4FsR2Fih4fUmJsaQ/RH8CaMA== X-Received: by 2002:a65:5807:0:b0:459:a31a:80c2 with SMTP id g7-20020a655807000000b00459a31a80c2mr39654909pgr.27.1666829776562; Wed, 26 Oct 2022 17:16:16 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id q11-20020a170902a3cb00b00174f7d107c8sm3421728plb.293.2022.10.26.17.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 17:16:16 -0700 (PDT) Date: Thu, 27 Oct 2022 00:16:12 +0000 From: Sean Christopherson To: Wei Wang Cc: pbonzini@redhat.com, dmatlack@google.com, vipinsh@google.com, ajones@ventanamicro.com, eric.auger@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 05/18] KVM: selftests/hardware_disable_test: code consolidation and cleanup Message-ID: References: <20221024113445.1022147-1-wei.w.wang@intel.com> <20221024113445.1022147-6-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024113445.1022147-6-wei.w.wang@intel.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Oct 24, 2022, Wei Wang wrote: > Remove the unnecessary definition of the threads[] array, and use the > helper functions to create and join threads. > > Also move setting of the thread affinity to __vcpu_thread_create using > attribute. This avoids an explicit step to set it after thread > creation. As David called out, please do this in a separate patch (one logical change per patch). > Signed-off-by: Wei Wang > --- > .../selftests/kvm/hardware_disable_test.c | 56 +++++-------------- > 1 file changed, 15 insertions(+), 41 deletions(-) > > diff --git a/tools/testing/selftests/kvm/hardware_disable_test.c b/tools/testing/selftests/kvm/hardware_disable_test.c > index f5d59b9934f1..c212d34a6714 100644 > --- a/tools/testing/selftests/kvm/hardware_disable_test.c > +++ b/tools/testing/selftests/kvm/hardware_disable_test.c > @@ -8,7 +8,6 @@ > #define _GNU_SOURCE > > #include > -#include > #include > #include > #include > @@ -59,64 +58,39 @@ static void *sleeping_thread(void *arg) > pthread_exit(NULL); > } > > -static inline void check_create_thread(pthread_t *thread, pthread_attr_t *attr, > - void *(*f)(void *), void *arg) > -{ > - int r; > - > - r = pthread_create(thread, attr, f, arg); > - TEST_ASSERT(r == 0, "%s: failed to create thread", __func__); > -} > - > -static inline void check_set_affinity(pthread_t thread, cpu_set_t *cpu_set) > -{ > - int r; > - > - r = pthread_setaffinity_np(thread, sizeof(cpu_set_t), cpu_set); > - TEST_ASSERT(r == 0, "%s: failed set affinity", __func__); > -} > - > -static inline void check_join(pthread_t thread, void **retval) > -{ > - int r; > - > - r = pthread_join(thread, retval); > - TEST_ASSERT(r == 0, "%s: failed to join thread", __func__); > -} > - > static void run_test(uint32_t run) > { > struct kvm_vcpu *vcpu; > struct kvm_vm *vm; > cpu_set_t cpu_set; > - pthread_t threads[VCPU_NUM]; > pthread_t throw_away; > - void *b; > + pthread_attr_t attr; > uint32_t i, j; > + int r; > > CPU_ZERO(&cpu_set); > for (i = 0; i < VCPU_NUM; i++) > CPU_SET(i, &cpu_set); Uh, what is this test doing? I assume the intent is to avoid spamming all pCPUs in the system, but I don't get the benefit of doing so.