From: Sean Christopherson <seanjc@google.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, maz@kernel.org,
dmatlack@google.com, oupton@google.com, ricarkol@google.com
Subject: Re: [PATCH v8 2/4] KVM: selftests: create -r argument to specify random seed
Date: Fri, 28 Oct 2022 20:49:34 +0000 [thread overview]
Message-ID: <Y1xAXtnQyTqbIMVE@google.com> (raw)
In-Reply-To: <20221027205631.340339-3-coltonlewis@google.com>
On Thu, Oct 27, 2022, Colton Lewis wrote:
> diff --git a/tools/testing/selftests/kvm/lib/perf_test_util.c b/tools/testing/selftests/kvm/lib/perf_test_util.c
> index 9618b37c66f7..5f0eebb626b5 100644
> --- a/tools/testing/selftests/kvm/lib/perf_test_util.c
> +++ b/tools/testing/selftests/kvm/lib/perf_test_util.c
> @@ -49,6 +49,7 @@ void perf_test_guest_code(uint32_t vcpu_idx)
> uint64_t gva;
> uint64_t pages;
> int i;
> + struct guest_random_state rand_state = new_guest_random_state(pta->random_seed + vcpu_idx);
This belong in the first patch that consumes rand_state, which I believe is patch 3.
lib/perf_test_util.c: In function ‘perf_test_guest_code’:
lib/perf_test_util.c:52:35: error: unused variable ‘rand_state’ [-Werror=unused-variable]
52 | struct guest_random_state rand_state = new_guest_random_state(pta->random_seed + vcpu_idx);
|
next prev parent reply other threads:[~2022-10-28 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 20:56 [PATCH v8 0/4] KVM: selftests: randomize memory access of dirty_log_perf_test Colton Lewis
2022-10-27 20:56 ` [PATCH v8 1/4] KVM: selftests: implement random number generator for guest code Colton Lewis
2022-10-27 20:56 ` [PATCH v8 2/4] KVM: selftests: create -r argument to specify random seed Colton Lewis
2022-10-28 20:49 ` Sean Christopherson [this message]
2022-10-31 16:05 ` Colton Lewis
2022-10-27 20:56 ` [PATCH v8 3/4] KVM: selftests: randomize which pages are written vs read Colton Lewis
2022-10-27 20:56 ` [PATCH v8 4/4] KVM: selftests: randomize page access order Colton Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1xAXtnQyTqbIMVE@google.com \
--to=seanjc@google.com \
--cc=coltonlewis@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox