From: Sean Christopherson <seanjc@google.com>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, zhenyuw@linux.intel.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com
Subject: Re: [PATCH v2 2/3] drm/i915/gvt: switch from track_flush_slot to track_remove_slot
Date: Fri, 11 Nov 2022 17:07:35 +0000 [thread overview]
Message-ID: <Y26BV9a9q8nBz/+7@google.com> (raw)
In-Reply-To: <20221111103436.22381-1-yan.y.zhao@intel.com>
On Fri, Nov 11, 2022, Yan Zhao wrote:
> KVMGT only cares about when a slot is indeed removed.
> So switch to use track_remove_slot which is called when a slot is removed.
This should capture the original motivation, i.e. that the existing
->track_flush_slot() hook is theoretically flawed. I think it also makes sense
to call out that KVMGT undoubtedly does the wrong thing if a memslot is moved,
but that (a) KVMGT has never supported moving memslots and (b) there's no sane
use case for moving memslots that might be used by the guest for the GTT.
Bonus points if you can figure out a way to capture the restriction in the docs,
e.g. somewhere in gpu/i915.rst?
Lastly, provide a link to the original discussion which provides even more context.
Link: https://lore.kernel.org/all/20221108084416.11447-1-yan.y.zhao@intel.com
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
> ---
next prev parent reply other threads:[~2022-11-11 17:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 10:32 [PATCH v2 0/3] add track_remove_slot and remove track_flush_slot Yan Zhao
2022-11-11 10:33 ` [PATCH v2 1/3] KVM: x86: add a new page track hook track_remove_slot Yan Zhao
2022-11-11 18:19 ` Sean Christopherson
2022-11-12 0:03 ` Yan Zhao
2022-11-12 0:43 ` Sean Christopherson
2022-11-14 1:05 ` Yan Zhao
2022-11-14 16:32 ` Sean Christopherson
2022-11-14 22:42 ` Yan Zhao
2022-11-14 23:24 ` Sean Christopherson
2022-11-14 23:22 ` Yan Zhao
2022-11-15 0:55 ` Sean Christopherson
2022-11-15 1:08 ` Yan Zhao
2022-11-11 10:34 ` [PATCH v2 2/3] drm/i915/gvt: switch from track_flush_slot to track_remove_slot Yan Zhao
2022-11-11 17:07 ` Sean Christopherson [this message]
2022-11-12 0:05 ` Yan Zhao
2022-11-11 10:35 ` [PATCH v2 3/3] KVM: x86: Remove the unused page track hook track_flush_slot Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y26BV9a9q8nBz/+7@google.com \
--to=seanjc@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yan.y.zhao@intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox