public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yan Zhao <yan.y.zhao@intel.com>
Subject: Re: [PATCH 0/2] KVM: x86/mmu: Use page-track only for... page tracking
Date: Fri, 11 Nov 2022 19:24:55 +0000	[thread overview]
Message-ID: <Y26hhw8yD96Z4eZf@google.com> (raw)
In-Reply-To: <20221110014821.1548347-1-seanjc@google.com>

On Thu, Nov 10, 2022, Sean Christopherson wrote:
> Don't bounce through the page-track notifier when zapping+flushing SPTEs
> in response to memslot changes as the need to zap+flush isn't strictly
> limited to page-tracking.  With that done, register KVM's notifier on the
> first allocation of a shadow root, as KVM's ->track_write() hook is used
> only to react to writes to gPTEs.
> 
> Aside from avoiding a RETPOLINE on emulated writes, dropping KVM's internal
> use will allow removing ->track_flush_slot() altogether once KVM-GT moves
> to a different hook[*].  Tracking "flushes" of slots is a poor fit for
> KVM-GT's needs as KVM-GT needs to drop its write-protection only when a
> memslot change is guaranteed to be committed, whereas the "flush" call is
> speculative in the sense that KVM may abort a memslot update after flushing
> the original memslot.
> 
> https://lore.kernel.org/all/20221108084416.11447-1-yan.y.zhao@intel.com
> 
> Sean Christopherson (2):
>   KVM: x86/mmu: Don't rely on page-track mechanism to flush on memslot
>     change
>   KVM: x86/mmu: Register page-tracker on first shadow root allocation

Don't merge this series, I'm going to (hopefully) send a (much larger) v2 that
more aggressively cleans up the page tracker APIs, and will replace patch 2 with
a completely different patch.

      parent reply	other threads:[~2022-11-11 19:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  1:48 [PATCH 0/2] KVM: x86/mmu: Use page-track only for... page tracking Sean Christopherson
2022-11-10  1:48 ` [PATCH 1/2] KVM: x86/mmu: Don't rely on page-track mechanism to flush on memslot change Sean Christopherson
2022-11-10  2:27   ` Yan Zhao
2022-11-10 17:08     ` Sean Christopherson
2022-11-11  2:18       ` Yan Zhao
2022-11-10  1:48 ` [PATCH 2/2] KVM: x86/mmu: Register page-tracker on first shadow root allocation Sean Christopherson
2022-11-11 19:24 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y26hhw8yD96Z4eZf@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox