From: Sean Christopherson <seanjc@google.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: pbonzini@redhat.com, dmatlack@google.com, andrew.jones@linux.dev,
wei.w.wang@intel.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 5/7] KVM: selftests: Shorten the test args in memslot_modification_stress_test.c
Date: Wed, 2 Nov 2022 23:45:56 +0000 [thread overview]
Message-ID: <Y2MBNA7pLIb6ugU2@google.com> (raw)
In-Reply-To: <20221102232737.1351745-6-vipinsh@google.com>
On Wed, Nov 02, 2022, Vipin Sharma wrote:
> Change test args memslot_modification_delay and nr_memslot_modifications
> to delay and nr_iterations for simplicity.
Suggested-by: Sean Christopherson <seanjc@google.com>
I don't care about the credit so much as I don't want you getting yelled at for
one of my random ideas :-)
> Signed-off-by: Vipin Sharma <vipinsh@google.com>
> ---
> .../kvm/memslot_modification_stress_test.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/memslot_modification_stress_test.c b/tools/testing/selftests/kvm/memslot_modification_stress_test.c
> index d7ddc8a105a2..d6089ccaa484 100644
> --- a/tools/testing/selftests/kvm/memslot_modification_stress_test.c
> +++ b/tools/testing/selftests/kvm/memslot_modification_stress_test.c
> @@ -87,8 +87,8 @@ static void add_remove_memslot(struct kvm_vm *vm, useconds_t delay,
> }
>
> struct test_params {
> - useconds_t memslot_modification_delay;
> - uint64_t nr_memslot_modifications;
> + useconds_t delay;
> + uint64_t nr_iterations;
> bool partition_vcpu_memory_access;
> };
>
> @@ -107,8 +107,8 @@ static void run_test(enum vm_guest_mode mode, void *arg)
>
> pr_info("Started all vCPUs\n");
>
> - add_remove_memslot(vm, p->memslot_modification_delay,
> - p->nr_memslot_modifications);
> + add_remove_memslot(vm, p->delay,
> + p->nr_iterations);
This wrap is no longer necessary (which was part of the motivation for the
rename).
> run_vcpus = false;
>
> @@ -144,8 +144,8 @@ int main(int argc, char *argv[])
> int max_vcpus = kvm_check_cap(KVM_CAP_MAX_VCPUS);
> int opt;
> struct test_params p = {
> - .memslot_modification_delay = 0,
> - .nr_memslot_modifications =
> + .delay = 0,
> + .nr_iterations =
> DEFAULT_MEMSLOT_MODIFICATION_ITERATIONS,
> .partition_vcpu_memory_access = true
> };
> @@ -158,8 +158,8 @@ int main(int argc, char *argv[])
> guest_modes_cmdline(optarg);
> break;
> case 'd':
> - p.memslot_modification_delay = atoi_paranoid(optarg);
> - TEST_ASSERT(p.memslot_modification_delay >= 0,
> + p.delay = atoi_paranoid(optarg);
> + TEST_ASSERT(p.delay >= 0,
> "A negative delay is not supported.");
> break;
> case 'b':
> @@ -175,7 +175,7 @@ int main(int argc, char *argv[])
> p.partition_vcpu_memory_access = false;
> break;
> case 'i':
> - p.nr_memslot_modifications = atoi_paranoid(optarg);
> + p.nr_iterations = atoi_paranoid(optarg);
> break;
> case 'h':
> default:
> --
> 2.38.1.273.g43a17bfeac-goog
>
next prev parent reply other threads:[~2022-11-02 23:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 23:27 [PATCH v8 0/7] dirty_log_perf_test vCPU pinning Vipin Sharma
2022-11-02 23:27 ` [PATCH v8 1/7] KVM: selftests: Add missing break between -e and -g option in dirty_log_perf_test Vipin Sharma
2022-11-02 23:27 ` [PATCH v8 2/7] KVM: selftests: Put command line options in alphabetical order " Vipin Sharma
2022-11-02 23:27 ` [PATCH v8 3/7] KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi() Vipin Sharma
2022-11-03 0:18 ` Sean Christopherson
2022-11-02 23:27 ` [PATCH v8 4/7] KVM: selftests: Use SZ_1G from sizes.h in max_guest_memory_test.c Vipin Sharma
2022-11-02 23:44 ` Sean Christopherson
2022-11-02 23:27 ` [PATCH v8 5/7] KVM: selftests: Shorten the test args in memslot_modification_stress_test.c Vipin Sharma
2022-11-02 23:45 ` Sean Christopherson [this message]
2022-11-03 0:16 ` Sean Christopherson
2022-11-03 18:56 ` Vipin Sharma
2022-11-02 23:27 ` [PATCH v8 6/7] KVM: selftests: Add atoi_positive() and atoi_non_negative() for input validation Vipin Sharma
2022-11-03 0:17 ` Sean Christopherson
2022-11-02 23:27 ` [PATCH v8 7/7] KVM: selftests: Allowing running dirty_log_perf_test on specific CPUs Vipin Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2MBNA7pLIb6ugU2@google.com \
--to=seanjc@google.com \
--cc=andrew.jones@linux.dev \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vipinsh@google.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).