From: David Matlack <dmatlack@google.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, maz@kernel.org,
seanjc@google.com, oupton@google.com, ricarkol@google.com
Subject: Re: [PATCH v9 3/4] KVM: selftests: randomize which pages are written vs read
Date: Thu, 3 Nov 2022 09:30:20 -0700 [thread overview]
Message-ID: <Y2PsnAGvwyd0BW6K@google.com> (raw)
In-Reply-To: <20221102160007.1279193-4-coltonlewis@google.com>
On Wed, Nov 02, 2022 at 04:00:06PM +0000, Colton Lewis wrote:
> Randomize which pages are written vs read using the random number
> generator.
>
> Change the variable wr_fract and associated function calls to
> write_percent that now operates as a percentage from 0 to 100 where X
> means each page has an X% chance of being written. Change the -f
> argument to -w to reflect the new variable semantics. Keep the same
> default of 100% writes.
>
> Population always uses 100% writes to ensure all memory is actually
> populated and not just mapped to the zero page. The prevents expensive
> copy-on-write faults from occurring during the dirty memory iterations
> below, which would pollute the performance results.
>
> Signed-off-by: Colton Lewis <coltonlewis@google.com>
Reviewed-by: David Matlack <dmatlack@google.com>
next prev parent reply other threads:[~2022-11-03 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 16:00 [PATCH v9 0/4] randomize memory access of dirty_log_perf_test Colton Lewis
2022-11-02 16:00 ` [PATCH v9 1/4] KVM: selftests: implement random number generator for guest code Colton Lewis
2022-11-02 23:22 ` Sean Christopherson
2022-11-03 16:34 ` David Matlack
2022-11-07 18:14 ` Colton Lewis
2022-11-02 16:00 ` [PATCH v9 2/4] KVM: selftests: create -r argument to specify random seed Colton Lewis
2022-11-02 23:35 ` Sean Christopherson
2022-11-03 16:27 ` David Matlack
2022-11-07 18:18 ` Colton Lewis
2022-11-02 16:00 ` [PATCH v9 3/4] KVM: selftests: randomize which pages are written vs read Colton Lewis
2022-11-03 16:30 ` David Matlack [this message]
2022-11-02 16:00 ` [PATCH v9 4/4] KVM: selftests: randomize page access order Colton Lewis
2022-11-03 16:32 ` David Matlack
2022-11-02 23:38 ` [PATCH v9 0/4] randomize memory access of dirty_log_perf_test Sean Christopherson
2022-11-02 23:55 ` David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2PsnAGvwyd0BW6K@google.com \
--to=dmatlack@google.com \
--cc=coltonlewis@google.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox