From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 232F9C43217 for ; Wed, 9 Nov 2022 15:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232046AbiKIPZv (ORCPT ); Wed, 9 Nov 2022 10:25:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232035AbiKIPZt (ORCPT ); Wed, 9 Nov 2022 10:25:49 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF0F0BE0F for ; Wed, 9 Nov 2022 07:25:48 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so2261232pji.0 for ; Wed, 09 Nov 2022 07:25:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Rp+1lx+FWBGvp1Xrs2hIQiVvxWYkY1FvZMZLEL/FwE0=; b=Y77a3zKqdZRf7diXlm3O31pEh/kZgqy7eVWwCKzcuLgQaUuxn5a/pfJYYQS6utyaca ppF5vk+V0PwQXTGyqOrdz6ANLgpN2BWwQrBnSoPKYm5GcdNvlkmaWWDab2X/6c+h5Hp8 IbLz/mRLkeDPKrZbp5LBXTnXcoHhpgZNbet8PC+mddfGgQI9P0dQFnZoRt0Fs4nYDx/t QLV0MhuE9WUW86WUmubRN5CCAiVGMKqqg0s5+AbeCg1DXc22KSxrorUvsn3l8Mc9AS6x Gk/PDQST2Zu9aSkOktE1QtS0A1vrRg/e3Sj06h0nkhgLdUm4qX9vdq7XQB/47ZV+2RgS dYxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rp+1lx+FWBGvp1Xrs2hIQiVvxWYkY1FvZMZLEL/FwE0=; b=LzdpA+9dNNZGZP1T1+EM6geOfNis5anTRjPLYPIkMB5q7UpRtv/hyAYOpDQ1qkBGlh x7IaoO/gHZ4KytV03Xy39bHveYe+Smx2DomDoAB4VCoxyY16O9OYP+YGnzo/JZ6TZPTw fRAyr9sjg65DGOxAujiU0qlDwCAepp/QIby5s+vpLIpiva06L0/15M/7YP3xFxqiNACc iuJkRXa7O8MeDq2LOVE8uvypFbueJ7ES48lq7VaTXQKiksnP/pluvocRqAAXVu6wIEu+ tTRl230CUUbvccDeudvY5lADyFrwSQWF8DrQ0dscD2shCEFtosniXrv8l8Fam65bFYDc RA6w== X-Gm-Message-State: ACrzQf0OaNRJV0NGL1IumHJhb2dxrt3vZqYnbbmJPWnjken9+ChXt0kj es//fmXzWmzPW0h3tIo6O6pvfg== X-Google-Smtp-Source: AMsMyM55pKnPSGRFYNOdBqVC54AssWJl/EMz1je0gdCgBf7K1JU4s7TVylkYFnjJ0F0AxtmfZ7jFYA== X-Received: by 2002:a17:902:8345:b0:188:5dbc:5c9b with SMTP id z5-20020a170902834500b001885dbc5c9bmr32424205pln.118.1668007548142; Wed, 09 Nov 2022 07:25:48 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id q17-20020aa79611000000b00565c860bf83sm8453738pfg.150.2022.11.09.07.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 07:25:47 -0800 (PST) Date: Wed, 9 Nov 2022 15:25:44 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, thomas.lendacky@amd.com, jmattson@google.com, stable@vger.kernel.org Subject: Re: [PATCH 04/11] KVM: SVM: retrieve VMCB from assembly Message-ID: References: <20221109145156.84714-1-pbonzini@redhat.com> <20221109145156.84714-5-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109145156.84714-5-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Nov 09, 2022, Paolo Bonzini wrote: > Continue moving all accesses to struct vcpu_svm directly in vmenter.S. > This limits the confusion due to different registers used for > argument passing in 32- and 64-bit ABIs. > > It is not strictly necessary for __svm_sev_es_vcpu_run, but staying It's not strictly necessary at all ;-) __svm_sev_es_vcpu_run() > consistent is a good idea since it makes __svm_sev_es_vcpu_run a __svm_sev_es_vcpu_run() > stripped version of _svm_vcpu_run. Missed an underscore. And parantheses. > No functional change intended. > > Cc: stable@vger.kernel.org > Fixes: a149180fbcf3 ("x86: Add magic AMD return-thunk") > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Sean Christopherson