From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D477EC433FE for ; Wed, 23 Nov 2022 17:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238838AbiKWRsT (ORCPT ); Wed, 23 Nov 2022 12:48:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238506AbiKWRsR (ORCPT ); Wed, 23 Nov 2022 12:48:17 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4F7A5CD0B for ; Wed, 23 Nov 2022 09:48:15 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id w15-20020a17090a380f00b0021873113cb4so2516945pjb.0 for ; Wed, 23 Nov 2022 09:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YzrL02JdEOvJNF7Jtm6mOFZtcnU8RnnoI7dq0vaKkEU=; b=q1TRSyGvqBioq3tfh3//gpbNDNamy468ziIjM+NNotYgTNywXifLRDACuuBgcbviSt mOc4dSkVQTg43f2eBUHNotAE5Yq9dd1TDCEoreLEAyzJyviwYISFJdelynuJyUTYOQPF qs6cei0wbTDTaiNggmsYjyCXlRxoywP+pZ/aHeg+CCxTkZciu9wz5pSVW+5G1Wvi2WI+ S0h3UxSJyIOw/G+BVuQYiFu90inrUGL8n7jth1J6BTFJbo3YKHzZ0XpoJ8ncGMLtJCes xb0eelzMTkupcpucjGAJhiaE1wbFBvicACfsCG6tEXiF6XP7pCk66cHdbO/C5VqeLT6a TpNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YzrL02JdEOvJNF7Jtm6mOFZtcnU8RnnoI7dq0vaKkEU=; b=KOCO0Q7Ja1OCy0fHL7DCJSg2nvh+rdc2ljGj0OocUm0Wm8gcBIRcniK19bnnuoh34H H9434JT0yUQHPAYWuKaMhq2fpqvqngRLNPRLHcOeuf8778x8hFilph8aZW9wR+Cu2iaz 2ZGpE26m8xE22hYw2RNgN34+NAsGyogWxdRpBrOnJw8YcHg/Hb7UUM2/7LWJFcnnsYJx xO9LAPxHCE3ldlYmyaefZguAMV0fMwCixsJYHh5u6mRKY0ro2yuK30gFEIkZtUTJgpvc lcHjjAK6TJR5i318onL4VAr4g8ITryMbZMV6+1b1cPfTvQTpxyPY/tDRPoYX01TGzwE/ 5ESA== X-Gm-Message-State: ANoB5pleDJj6N9xGykBy3vbvZptNTkZ6FlcVHK40+1i0FfQBi0IV6pRE Odkoom501OjvKECwx3060vhvCg== X-Google-Smtp-Source: AA0mqf5owaqykZA0kUarbc6tzXu+YrAUpt94JD9fda07SKqPgLJRkCzpQ+fUQZWZYQyYpEnO2NvbgQ== X-Received: by 2002:a17:90b:1987:b0:218:d339:1b85 with SMTP id mv7-20020a17090b198700b00218d3391b85mr7792609pjb.122.1669225695255; Wed, 23 Nov 2022 09:48:15 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id h19-20020a656393000000b0044ed37dbca8sm11169615pgv.2.2022.11.23.09.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 09:48:14 -0800 (PST) Date: Wed, 23 Nov 2022 17:48:11 +0000 From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Durrant Subject: Re: [PATCH] KVM: x86/xen: Make number of event channels defines less magical Message-ID: References: <20221114181632.3279119-1-seanjc@google.com> <629d6d90ce95b9db74f0101a4428be1119c4bfc7.camel@infradead.org> <9d0e54e248c740eb52bcaa63764afb99a4dfcde9.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d0e54e248c740eb52bcaa63764afb99a4dfcde9.camel@infradead.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Nov 22, 2022, David Woodhouse wrote: > On Tue, 2022-11-22 at 20:31 +0000, Sean Christopherson wrote: > How's something like this? I did start typing that comment in the > max_evtchn_port() function in xen.c but moved it over. > > Still not utterly convinced, as it's still somewhat circular — we now > define NR_CHANNELS as (32*32) with a big comment explaining *why* that > is, and the reason is basically "because that's the number of bits in > an array of uint32_t[32]". Agreed, probably not an improvement across the board. Consistency with how the non-compat code declares the fields is also valuable, so unless someone changes upstream Xen code, let's just leave things as-is.