From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79797C433FE for ; Wed, 16 Nov 2022 17:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238808AbiKPRgY (ORCPT ); Wed, 16 Nov 2022 12:36:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234020AbiKPRgV (ORCPT ); Wed, 16 Nov 2022 12:36:21 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0606459FDB for ; Wed, 16 Nov 2022 09:36:21 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id v3so17320225pgh.4 for ; Wed, 16 Nov 2022 09:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uMpyhPRo49yCYtDdWLnPUG6w8J9G3yX4v+y+FzJTCjI=; b=P4lcupnFe3arFwzI/RBiDY1CkjkCFPn44C2NQbdzi7VF192uxSML8weiuFgHVgrb9C /rRhMFOM3hQLU6MCnkftFr+Cl1mO/Zoto/73UgmSLvx1vW0Yrxwy38E6s4nOOmIM1hZ8 jF2n/oObkKjqXF653GuRNOxAj1wLas0nRL45IVHF42OHau/qkP/OHGjWO0wzpc7Ci+Hv 02P5tCLZzyDFHH9cIkXq23NKv/23jzy9jVe5/sAvzqNlHOnX7vnYN+q4TAIlZOm2TAg6 8/jFcvbTeqiFWrHS9TksJmnirKuckgKR+dXmZcbmOFuKE6KKEQ1Fvf8PJiWyJGqje0eZ Ocdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uMpyhPRo49yCYtDdWLnPUG6w8J9G3yX4v+y+FzJTCjI=; b=jTdVRJCIragAAxg5qXhrkBrrP66d58bNTTFGt/mvh6m6AAyk0Xx0f2WiM1PECZORHu twXXpltrMTT5Bj81RkTp83BvRtmDndMRxc5xHGCFm31CH4+rFSGTV5l4cj1nfz5USHY0 tCwtRxUsVvK2XExD3/XuIV50kz9q8yolrpCQ/LRhUZmNiinKr2rBhkABHNFa28874Tz/ BRp4R/90hOr439ZmOWV3hq5QW0p2C6N370yfZfFt3eN5cZ3pJCUxP7XO/N2xcpltoJnV zisB31hudf0Hyj9KokORPdCH0T4oCoj0eOIm89884GNTC7d4kSIsgmNeKYDWeqIX5Z+G fz5g== X-Gm-Message-State: ANoB5pmxKlGptNXh3wvBI5fL9/3YolSUvgiCfYi5+I8t12sH65pvN45a BJDgULXok34fOV698gsY2NAmcA== X-Google-Smtp-Source: AA0mqf47RLQKtt8wsQd5KbME8R0MEGBnP3uaGwhfFvDROmU7GuT9E67J84o92BN7xsr0rD07zgUhrA== X-Received: by 2002:a62:506:0:b0:56d:4b31:c4d9 with SMTP id 6-20020a620506000000b0056d4b31c4d9mr24532107pff.44.1668620180412; Wed, 16 Nov 2022 09:36:20 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id x17-20020a170902ec9100b00176e6f553efsm12555425plg.84.2022.11.16.09.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 09:36:19 -0800 (PST) Date: Wed, 16 Nov 2022 17:36:16 +0000 From: Sean Christopherson To: Vishal Annapurve Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org, bgardon@google.com, oupton@google.com, peterx@redhat.com, vkuznets@redhat.com, dmatlack@google.com, pgonda@google.com, andrew.jones@linux.dev Subject: Re: [V4 PATCH 1/3] KVM: selftests: move common startup logic to kvm_util.c Message-ID: References: <20221115213845.3348210-1-vannapurve@google.com> <20221115213845.3348210-2-vannapurve@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115213845.3348210-2-vannapurve@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Nov 15, 2022, Vishal Annapurve wrote: > Consolidate common startup logic in one place by implementing a single > setup function with __attribute((constructor)) for all selftests within > kvm_util.c. > > This allows moving logic like: > /* Tell stdout not to buffer its content */ > setbuf(stdout, NULL); > to a single file for all selftests. > > This will also allow any required setup at entry in future to be done in > common main function. > > More context is discussed at: > https://lore.kernel.org/lkml/Ywa9T+jKUpaHLu%2Fl@google.com/ Nit, Link: https://lore.kernel.org/lkml/Ywa9T+jKUpaHLu%2Fl@google.com is the the "standard" way to convey this information.