From: Sean Christopherson <seanjc@google.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: account allocation in generic version of kvm_arch_alloc_vm()
Date: Fri, 18 Nov 2022 17:30:38 +0000 [thread overview]
Message-ID: <Y3fBPl1YJHuQwLG+@google.com> (raw)
In-Reply-To: <Y3aay2u2KQgiR0un@p183>
Nit, please capitalize "KVM:" in the shortlog.
On Thu, Nov 17, 2022, Alexey Dobriyan wrote:
> This is persistent allocation and arch-specific versions account it.
The justification isn't that "x86 does it", e.g. the x86 code could be wrong.
The justification is that the allocation is tied to the current task as opposed
to being a KVM-wide allocation. It's worth calling out that x86 already accounts
its allocation, but that should be a footnote, not the reason for converting the
generic allocation.
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
With a reworded changelog,
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2022-11-18 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 20:34 [PATCH] kvm: account allocation in generic version of kvm_arch_alloc_vm() Alexey Dobriyan
2022-11-18 17:30 ` Sean Christopherson [this message]
2023-01-19 21:04 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3fBPl1YJHuQwLG+@google.com \
--to=seanjc@google.com \
--cc=adobriyan@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox