* [PATCH v2] KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd()
@ 2022-11-28 21:47 Wei Liu
2022-11-28 22:58 ` Sean Christopherson
2023-01-19 20:54 ` Sean Christopherson
0 siblings, 2 replies; 3+ messages in thread
From: Wei Liu @ 2022-11-28 21:47 UTC (permalink / raw)
To: kvm
Cc: Wei Liu, Sean Christopherson, Paolo Bonzini, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT), H. Peter Anvin,
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
There is no function named kvm_mmu_ensure_valid_pgd().
Fix the comment and remove the pair of braces to conform to Linux kernel
coding style.
Signed-off-by: Wei Liu <wei.liu@kernel.org>
---
v2: incorporate Sean's suggestions
---
arch/x86/kvm/mmu/mmu.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index b6f96d47e596..a1895fd9eaf4 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -4452,10 +4452,12 @@ void kvm_mmu_new_pgd(struct kvm_vcpu *vcpu, gpa_t new_pgd)
struct kvm_mmu *mmu = vcpu->arch.mmu;
union kvm_mmu_page_role new_role = mmu->root_role;
- if (!fast_pgd_switch(vcpu->kvm, mmu, new_pgd, new_role)) {
- /* kvm_mmu_ensure_valid_pgd will set up a new root. */
+ /*
+ * Return immediately if no usable root was found, kvm_mmu_reload()
+ * will establish a valid root prior to the next VM-Enter.
+ */
+ if (!fast_pgd_switch(vcpu->kvm, mmu, new_pgd, new_role))
return;
- }
/*
* It's possible that the cached previous root page is obsolete because
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd()
2022-11-28 21:47 [PATCH v2] KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd() Wei Liu
@ 2022-11-28 22:58 ` Sean Christopherson
2023-01-19 20:54 ` Sean Christopherson
1 sibling, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2022-11-28 22:58 UTC (permalink / raw)
To: Wei Liu
Cc: kvm, Paolo Bonzini, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
H. Peter Anvin, open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
On Mon, Nov 28, 2022, Wei Liu wrote:
> There is no function named kvm_mmu_ensure_valid_pgd().
>
> Fix the comment and remove the pair of braces to conform to Linux kernel
> coding style.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd()
2022-11-28 21:47 [PATCH v2] KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd() Wei Liu
2022-11-28 22:58 ` Sean Christopherson
@ 2023-01-19 20:54 ` Sean Christopherson
1 sibling, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2023-01-19 20:54 UTC (permalink / raw)
To: Sean Christopherson, kvm, Wei Liu
Cc: Paolo Bonzini, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86, H. Peter Anvin, linux-kernel
On Mon, 28 Nov 2022 21:47:09 +0000, Wei Liu wrote:
> There is no function named kvm_mmu_ensure_valid_pgd().
>
> Fix the comment and remove the pair of braces to conform to Linux kernel
> coding style.
>
>
Applied to kvm-x86 mmu, thanks!
[1/1] KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd()
https://github.com/kvm-x86/linux/commit/03e5fdfd708e
--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-19 21:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 21:47 [PATCH v2] KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd() Wei Liu
2022-11-28 22:58 ` Sean Christopherson
2023-01-19 20:54 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).