From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF228C47088 for ; Thu, 1 Dec 2022 02:07:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbiLACHX (ORCPT ); Wed, 30 Nov 2022 21:07:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbiLACHW (ORCPT ); Wed, 30 Nov 2022 21:07:22 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F9139D814 for ; Wed, 30 Nov 2022 18:07:20 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so3796034pjc.3 for ; Wed, 30 Nov 2022 18:07:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7Yv+muzPKYyoo83bWuTuoWw9IavMvQEWUUPYi5mla7w=; b=nu7QmhaB5OU8Sz87xzT0B/TDbai2tkzlc8q8PMFAVC6MmY5ORSCDXElnwD5AeyHTfU tQY11jozUluEkW9FOiPUqvg1K2Ad20U+kvZGZsd3j0A9uXZLxsEDaCMW3TEu3rZFnJAL y4ReCeui3IxbT0xBUXK5visY533ogW747HkAdHzpFlZRzWGj38cLleZyLcFF4+nMLbkq sO+gd9QsBsVD13i66CYdr7XLlkLCGb0IGzkIFe5R4zD8VeU0G4puf/2owFqvYC+u8Nmk 5f+5aRCjLF0wgzUDxwWBnpsXi9NG6o+joQjmCsGTy75OphDg0GADwMHeO7EHo1Dlq+A2 7vRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Yv+muzPKYyoo83bWuTuoWw9IavMvQEWUUPYi5mla7w=; b=La89zkS5U12aDsa3l1ZlmqKzwgDI9X/vTMHFzb5dGXXi8PARmtS1Ws3oy8Lci4F5kL mur6dNiN4HgZ/kIBmTKBQPDdKLgU0yqNphgI3bnJ//0ffmlAlT9t1FyFNFX2+jCEaXyB PpeQDV5ZVfpDV/wbBGMTtN4W/Cnyuc+TUDdKfD8y4l+K8N3dmXzzKWtiMfSMCwCd83V9 7jD1laVI44WvVtkqvqVkCAAOhhwP9MKR4a6jPRmdb3Z1eZeoQwmIMXpGLRK8GTdp/Sfb tbu09BT0uEQ3XlL7PQlNldDGgSMGZrnWe5fTcaVHUawUAaLlW0esCJLgQQuh+8UhHHtL jnPA== X-Gm-Message-State: ANoB5pnMnscPqEY2YCIEZGTSklFECURTSdjoKrHJ6nqnq3co58mDrhLL eqk13HW0UVW2l/xM3ip6QhbiUQ== X-Google-Smtp-Source: AA0mqf7TrFs8X1Ox0jXmGnlp6X7ZU+swoypahjfGlG54Z6D/xl4AlojOuynTre1dZOAXA5aGhwHUgg== X-Received: by 2002:a17:90a:8417:b0:210:9e08:d577 with SMTP id j23-20020a17090a841700b002109e08d577mr75432375pjn.134.1669860439764; Wed, 30 Nov 2022 18:07:19 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id k1-20020a170902c40100b0017e64da44c5sm2164639plk.203.2022.11.30.18.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 18:07:19 -0800 (PST) Date: Thu, 1 Dec 2022 02:07:15 +0000 From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/14] KVM: x86: Remove unnecessary export of kvm_vcpu_is_reset_bsp() Message-ID: References: <20221114095606.39785-1-likexu@tencent.com> <20221114095606.39785-11-likexu@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114095606.39785-11-likexu@tencent.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Nov 14, 2022, Like Xu wrote: > From: Like Xu > > Don't export x86's kvm_vcpu_is_reset_bsp(), the helper isn't used by > KVM x86's vendor modules. Move up the code block out of existing > callers' need. Again, no. kvm_vcpu_is_reset_bsp() is declared by kvm_vcpu_is_reset_bsp(). The lack of "static" is the first clue, and the fact that KVM compiles without issue today is the second clue. EXPORT_SYMBOL_GPL() only affects resolving module dependencies, it doesn't provide any information to the compiler about function prototypes. > Signed-off-by: Like Xu > --- > arch/x86/kvm/x86.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index f325710a4f25..f3cb3e02bfa6 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -11496,6 +11496,11 @@ int kvm_arch_vcpu_precreate(struct kvm *kvm, unsigned int id) > return static_call(kvm_x86_vcpu_precreate)(kvm); > } > > +bool kvm_vcpu_is_reset_bsp(struct kvm_vcpu *vcpu) > +{ > + return vcpu->kvm->arch.bsp_vcpu_id == vcpu->vcpu_id; > +} > + > int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu) > { > struct page *page; > @@ -11993,12 +11998,6 @@ int kvm_arch_check_processor_compat(void *opaque) > return ops->check_processor_compatibility(); > } > > -bool kvm_vcpu_is_reset_bsp(struct kvm_vcpu *vcpu) > -{ > - return vcpu->kvm->arch.bsp_vcpu_id == vcpu->vcpu_id; > -} > -EXPORT_SYMBOL_GPL(kvm_vcpu_is_reset_bsp); > - > bool kvm_vcpu_is_bsp(struct kvm_vcpu *vcpu) > { > return (vcpu->arch.apic_base & MSR_IA32_APICBASE_BSP) != 0; > -- > 2.38.1 >