From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F78C47089 for ; Wed, 7 Dec 2022 16:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbiLGQbh (ORCPT ); Wed, 7 Dec 2022 11:31:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbiLGQbf (ORCPT ); Wed, 7 Dec 2022 11:31:35 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAF7525E90 for ; Wed, 7 Dec 2022 08:31:34 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id jl24so17506133plb.8 for ; Wed, 07 Dec 2022 08:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l3tHC8UqGNgJNk6TUIr7bCokV90g8koZJwnZS2XdsT8=; b=Bzv/XCuwwJeZpjtRBlwO9DkjSATcs16n9qA3P9iyyDu7jYUvKcPWPmGcoa3v8Gqy2H s5JtXDeazntWePvMSvPmhL2nEhTEjASGm6tcFws5Zx0J9k27Ui1g16FoVhA1FYR752YO AP7tewK1w+ChRx+hN2XVejvySz6oPhTVMXrs6XlW+FKjWXbiLfR1vdsb6jYU96aU77K6 K2yekX0/qMqhDCMnlyZCckcGLvAvse+ijkIu2pAC98vcRZ3LM9e5RbVnTJ9QPvnhIbMs ZtBmSKQ3jUb4grz+NtOBOOTyIaIhXpd7K05JlTFFru1ikNx0Y8Q5y6mfbMy/lWvwW9t0 E4vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l3tHC8UqGNgJNk6TUIr7bCokV90g8koZJwnZS2XdsT8=; b=LC/Q+675YwmvFsZFqGMWGyqXPEimD3h5+zJ73R/LKdYmm7BmZ9pKc3zUYnPmifKjLq 9/WOcJLdnGXT4fosEkZmPW5pHB64MbgARq/egCaGaNLc/1fY2S8jU7dC61xNXA286l7x 7LbTwbnsYCN1TRsoJDGApmlIKgmoaF+q/kkt5xQiCn2AS2+7zY7nTKWx2Jo2G6S4rZVC 7IGtmx0PNyqgXwq6E9jW3cndIgMHEHJdpiszeckDAn3qCFPKXQejgh1aSqV61LuX6hw9 1UUSvULHTlSHBs/YvB/cTOTuaNy1Q8dpB9k4jeGfuA2VrrRFaMXzIK2gJy7z8rjcyeGx qa2g== X-Gm-Message-State: ANoB5pnGPSfoSVSRIInzIHLfc3DqsaVVDIWjqPZkdme/23FcSqQ95i4Y BB8buA/d38UP4auyc8xOAKyBPg== X-Google-Smtp-Source: AA0mqf7Qtio1AnDmo3m6zWhMSlgbTaneoN4QTCspu3qSGcyilWQUe0Gek8GBl/yxGHLPvLa+ZgcnUg== X-Received: by 2002:a17:902:e154:b0:189:6d32:afeb with SMTP id d20-20020a170902e15400b001896d32afebmr1142361pla.1.1670430694283; Wed, 07 Dec 2022 08:31:34 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id f17-20020a170902f39100b00178b9c997e5sm14769739ple.138.2022.12.07.08.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 08:31:33 -0800 (PST) Date: Wed, 7 Dec 2022 16:31:30 +0000 From: Sean Christopherson To: Atish Patra Cc: Atish Patra , linux-kernel@vger.kernel.org, Albert Ou , Anup Patel , Guo Ren , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paul Walmsley , Will Deacon Subject: Re: [RFC 8/9] RISC-V: KVM: Implement perf support Message-ID: References: <20220718170205.2972215-1-atishp@rivosinc.com> <20220718170205.2972215-9-atishp@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Dec 07, 2022, Atish Patra wrote: > On Fri, Dec 2, 2022 at 9:09 AM Sean Christopherson wrote: > > > > On Mon, Jul 18, 2022, Atish Patra wrote: > > > RISC-V SBI PMU & Sscofpmf ISA extension allows supporting perf in > > > the virtualization enviornment as well. KVM implementation > > > relies on SBI PMU extension for most of the part while traps > > > & emulates the CSRs read for counter access. > > > > For the benefit of non-RISCV people, the changelog (and documentation?) should > > explain why RISC-V doesn't need to tap into kvm_register_perf_callbacks(). > > As per my understanding, kvm_register_perf_callbacks is only useful > during event sampling for guests. Please let me know if I missed > something. > This series doesn't support sampling and guest counter overflow interrupt yet. > That's why kvm_register_perf_callbacks support is missing. Ah, I missed that connection in the cover letter. In the future, if a patch adds partial support for a thing/feature, it's very helpful to call that out in the lack shortlog and changelog, even for RFCs. E.g. adding a single word in the shortlog and sentence or two in the changelog doesn't take much time on your end, and helps avoid cases like this where drive-by reviewers like me from cause a fuss about non-issues. RISC-V: KVM: Implement partial perf support ... Counter overflow and interrupts are not supported as the relevant architectural specifications are still under discussion. Thanks!