From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EB4C4708D for ; Wed, 7 Dec 2022 23:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbiLGXpA (ORCPT ); Wed, 7 Dec 2022 18:45:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbiLGXo6 (ORCPT ); Wed, 7 Dec 2022 18:44:58 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95F428AAFE for ; Wed, 7 Dec 2022 15:44:54 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id k7so18543141pll.6 for ; Wed, 07 Dec 2022 15:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6iCaSQa1HFCfJ8+bX1upEoM6MTaIn0UmKgjdPtgAjjc=; b=KkMIutKijaPJLWWpORIH3M7DoEIXJXVArWkiJXMSz8T5xYL8iAo5sVXEy6sqiKL4Q6 GzONfdpncDOio5lHMt6K32MFchEpLDDS74m0k84wySF8/xUSWPDlRO2qHTFx5CJMTPXs Pz6umlCMMEx5buAmxJt9/iKpq4sAYZrlfHRHXCB8Qi05gvNYWM87iJwBVi1GJFkHaJdf ee9nlI6HgLtZD0zr9k1FZwi8siSZ1tDbxVjExGf5o7x44QyiPbec1tbcxkvIpEzPWM9t c8szkfNSqQIk+eipVkW44sLAkuj6/o8y3vDsWwtHW9Cp/VMEqkIeC4CwH84SP4Y+4+N9 mnbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6iCaSQa1HFCfJ8+bX1upEoM6MTaIn0UmKgjdPtgAjjc=; b=ABkBEw88JZzqZIXa2ifnkDfatwnI9B6mRkx8lFErGv2bw5pPcSw+i9Q/nvGyKMibH3 OHoZ4x9T269b3zX84j/wU8NfzTdp2UKSM9uaBmc/jhAKXtWvb/tSHOUmnJjAX+85naM2 /VjEaWv/wEQao3DAqfEbteR/vSCc6rGoepfGGeeozb1Kl4jxb7ygK3BBqfvlWmFigNjC h4r7hxfVJSzo2Qf5bs/bfbRCAgVJaKtRhihUGT3i9WCqVrS/m/UAVTG2bZFR2Q+wtZFE uoSIMyB7RKx2R2G6cmoc3vtWjb8DEJZsG4KB6X/886cMFZd/+qcR0oHW9mheMH6AQHvI Q3bQ== X-Gm-Message-State: ANoB5pmAY7LWOpK9Sdi4xAL3SM9IF4ldNbIP+KGEZJCbzmT8FaB7Lbbl 7RSRzEAu4+sqpigaS95z2uahmg== X-Google-Smtp-Source: AA0mqf5f+HSDTe/eFvdYT1KQV50ny+OsSgkb0jaUxxexfrGcapWSrpNJd+KINOsgbiEg2Rw5vCDanA== X-Received: by 2002:a17:90a:55c2:b0:219:f970:5119 with SMTP id o2-20020a17090a55c200b00219f9705119mr590148pjm.1.1670456693817; Wed, 07 Dec 2022 15:44:53 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id w10-20020a170902e88a00b001868ed86a95sm15155465plg.174.2022.12.07.15.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 15:44:53 -0800 (PST) Date: Wed, 7 Dec 2022 23:44:50 +0000 From: Sean Christopherson To: Oliver Upton Cc: Marc Zyngier , James Morse , Alexandru Elisei , Paolo Bonzini , Shuah Khan , Andrew Jones , Peter Gonda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kvmarm@lists.linux.dev, Ricardo Koller , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] KVM: selftests: Allocate ucall pool from MEM_REGION_DATA Message-ID: References: <20221207214809.489070-1-oliver.upton@linux.dev> <20221207214809.489070-5-oliver.upton@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207214809.489070-5-oliver.upton@linux.dev> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Dec 07, 2022, Oliver Upton wrote: > MEM_REGION_TEST_DATA is meant to hold data explicitly used by a > selftest, not implicit allocations due to the selftests infrastructure. > Allocate the ucall pool from MEM_REGION_DATA much like the rest of the > selftests library allocations. > > Fixes: 426729b2cf2e ("KVM: selftests: Add ucall pool based implementation") Not that it really matters because no one will backport this verbatim, but this is the wrong commit to blame. As of commit 426729b2cf2e, MEM_REGION_DATA does not exist. And similarly, the common ucall code didn't exist when Ricardo's series introduced MEM_REGION_DATA. $ git show 426729b2cf2e:tools/testing/selftests/kvm/include/kvm_util_base.h | grep MEM_REGION_DATA $ git show 290c5b54012b7:tools/testing/selftests/kvm/lib/ucall_common.c fatal: path 'tools/testing/selftests/kvm/lib/ucall_common.c' exists on disk, but not in '290c5b54012b7' The commit where the two collided is: Fixes: cc7544101eec ("Merge tag 'kvmarm-6.2' of https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm into HEAD") > Signed-off-by: Oliver Upton > --- Fixes nit aside, Reviewed-by: Sean Christopherson