From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5ADC4332F for ; Fri, 9 Dec 2022 19:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbiLITsL (ORCPT ); Fri, 9 Dec 2022 14:48:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiLITsJ (ORCPT ); Fri, 9 Dec 2022 14:48:09 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBD9229364 for ; Fri, 9 Dec 2022 11:48:07 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id fy4so5547521pjb.0 for ; Fri, 09 Dec 2022 11:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zQu0xHmezona1yp0QM9dAtI9Szifegp4YTL0XeOL4ws=; b=KxLrq1EpZy4M7WanlGgi3c9+zbE39YbH65vP0ep3ysHNOq02GB9CcLAGEZ2tpRTTo/ H9lXrY7cVOxAaEkbWbF8MpUBsNPGSog+dS/6vPOrNxeRiOG0vssepsytbE9TjqJZxzH8 has8/M+s2kNGv4kOUGYZ7b2SCcvuyfeU6ZTx8ywVnJaZ88Wm7LOL2N4Kt2FiCZTS+BTX Et30yE0LQBeuGBsIc2eh3QWi94H4e0nmYbIN9emHgQYDUv7ofLWLwed7T+371PiZ3a6m mUXzZT/h7khr0U2/GDXvO2+9zt9SY1WpDy8lkfm3EBTS3jy0xnFYftcWCwSsahPzeSJK 46hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zQu0xHmezona1yp0QM9dAtI9Szifegp4YTL0XeOL4ws=; b=TT7kLdk5cu3EziBgdZJk4sOTYUSLKiiCxGKGQUApYTm9jfM2Ej4tSGX3ptappUSz+X 47Hx3ZOyiND6WGknXbv9GpJlShJQ9VV3GajdylpS41yuvMY6KpLTLAmExlLNM86MGe5y mUzE45scAe3WVtIZCHxESNhcsqoW6eXpV4Pvqi8P94Y91T4zJijCZMBJ7W350JpN3CLL TWVE4wtviMzRHYGETSQILegvGxNUDc/n93b+5jz3VX327LZQLdJfBXPZwf00+9HHm9E1 45rESQK4tSTfEX6jsMl2aBaedW+49IlTpWMW29HTjW+Ia47KiLa541ruw1S2wC3cwa6m 3DNg== X-Gm-Message-State: ANoB5pmAckRaR234jaBcYUT/ULVyKA4VawKbVzlNJqnFi1Ci15Qjzyz1 QKbp2oHZB3RtdW7K2x2WSvUGSQ== X-Google-Smtp-Source: AA0mqf4flq+i9Vp0qY22m1GEIanI9xM7ZT69Q14Lx9EyzntEQOicmXDaqINBBGm6QxR9fg3WhVu9Cw== X-Received: by 2002:a17:902:6ac4:b0:185:441e:90c9 with SMTP id i4-20020a1709026ac400b00185441e90c9mr6523389plt.47.1670615287052; Fri, 09 Dec 2022 11:48:07 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id u2-20020a170902e5c200b0017ec1b1bf9fsm1677587plf.217.2022.12.09.11.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 11:48:06 -0800 (PST) Date: Fri, 9 Dec 2022 19:48:02 +0000 From: Carlos Llamas To: Stefano Garzarella Cc: Lee Jones , linux-kernel@vger.kernel.org, Ram Muthiah , "Michael S. Tsirkin" , Jason Wang , Stefan Hajnoczi , "David S. Miller" , Jakub Kicinski , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, jiang.wang@bytedance.com Subject: Re: [PATCH 1/1] virtio/vsock: Make vsock virtio packet buff size configurable Message-ID: References: <20210721143001.182009-1-lee.jones@linaro.org> <20210722125519.jzs7crke7yqfh73e@steredhat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722125519.jzs7crke7yqfh73e@steredhat> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jul 22, 2021 at 02:55:19PM +0200, Stefano Garzarella wrote: > > > > +uint virtio_transport_max_vsock_pkt_buf_size = 1024 * 64; > > +module_param(virtio_transport_max_vsock_pkt_buf_size, uint, 0444); > > +EXPORT_SYMBOL_GPL(virtio_transport_max_vsock_pkt_buf_size); > > + I'm interested on this functionality, so I could take this on. > > Maybe better to add an entry under sysfs similar to what Jiang proposed > here: > https://lists.linuxfoundation.org/pipermail/virtualization/2021-June/054769.html Having a look at Jiang's RFC patch it seems the proposed sysfs node hangs off from the main kernel object e.g. /sys/kernel. So I wonder if there is a more appropriate parent for this knob? Also, I noticed that Ram's patch here is using read-only permissions for the module parameter and switching to sysfs would mean opening this knob up to be dynamically configured? I'd need to be careful here. -- Carlos Llamas