From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A6CBC00145 for ; Mon, 12 Dec 2022 23:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229497AbiLLX0m (ORCPT ); Mon, 12 Dec 2022 18:26:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233994AbiLLX0k (ORCPT ); Mon, 12 Dec 2022 18:26:40 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE3A1704A for ; Mon, 12 Dec 2022 15:26:39 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id u5so1468204pjy.5 for ; Mon, 12 Dec 2022 15:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=LgVzXCUoiKNG9USGHdtxDWk3jXHPhUfF7aC6Jb6oAf8XA1bTwz+AQ/vH//iOu+Txbq HtNSM7bobeYY6HNyDm3070/s1Oas0aeVxdQOxg9nHQgvvOSD+HbQky0G3NWU2aHHH9iG JVh1AUDnlaepYuer6Ncinshp4+sTBfERSvbRGIUdHuN0fvrTLKzxKu4eop/o7jhMUBSa 9I1Z1oUAs6TpwbdTo0ilfAV5dpWM/KOAPcjBCaf+Wh+PzYd+4+Je5We3hpfEFSHW2X9B XNOJfuewe5Qh+b7VEFMhtgGppnAqVlzsDeqFiGrPyEqs9m8tEG3SEwVL1QUihijPEdBo 3YcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=5wV8vEHbpFTT+U+f61CFNUX9S5clRcvFHen5Z2nsubVh70bkOcyb6TGUAbjy7Guh9o WyeutXbu1Fic8cf/OetzYn9LxKSAKtwvmYvtekCtlcvgGnI42tTBwLj/lZKxaMNfJHMd RvAx3sCg6LgY4pOPcCp0GRR9rf9nkuF20xKHFzgiysZPzPfJvdu6EgLY8IJBQQNEAhE4 RYO00hT/mid7FrOkat/Dtm6ATCl9RTe1Wy0eDE4EZSUA3cvsHUeBQ5zaFT4cKv4oPIdE DheqGhLtqAZN9XHzH3sjpPaJmKnHJhuzOlSChp3SnrcjM1mEEAuhf4PoavTn5vEPh8rt +ASg== X-Gm-Message-State: ANoB5pnkQ9V6kzovxURe5LORcgIAGIFSOsxZXNTWS0gUvP7/Q3qxDonV a71HvIlldOWZL2YXxJ2f1mRwDw== X-Google-Smtp-Source: AA0mqf5Ct9lyTd0t0PIpKHrR2fvGzlGpqd0kxk6VIFCVK4Ckp27HzLLjvycFuCodXJHfa/pjm6FVZg== X-Received: by 2002:a17:902:da8d:b0:189:3a04:4466 with SMTP id j13-20020a170902da8d00b001893a044466mr16713plx.2.1670887599032; Mon, 12 Dec 2022 15:26:39 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id z9-20020a170903018900b00189af02aba4sm6992708plg.3.2022.12.12.15.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:26:38 -0800 (PST) Date: Mon, 12 Dec 2022 23:26:35 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Oliver Upton , David Matlack , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Anshuman Khandual , Nadav Amit , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Dec 12, 2022, Paolo Bonzini wrote: > On 12/9/22 20:07, Oliver Upton wrote: > > > - Naming. This series does not change the names of any existing code. > > > So all the KVM/x86 Shadow MMU-style terminology like > > > "shadow_page"/"sp"/"spte" persists. Should we keep that style in > > > common code or move toward something less shadow-paging-specific? > > > e.g. "page_table"/"pt"/"pte". > > > > I would strongly be in favor of discarding the shadow paging residue if > > x86 folks are willing to part ways with it 😄 > > Yes, absolutely. Something like to_shadow_page->to_mmu_data, sp->md, > spt->hpt, spte->spte, sptep->hptep. "host" will be confusing if when the primary MMU is involved though, e.g. I always think of the primary MMU's page tables as the "host page tables". What if we keep the "S" for SPT(E) and repurpose it to mean Secondary PTE?