From: Sean Christopherson <seanjc@google.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
柳菁峰 <liujingfeng@qianxin.com>
Subject: Re: [PATCH] KVM: Destroy target device if coalesced MMIO unregistration fails
Date: Tue, 3 Jan 2023 16:33:39 +0000 [thread overview]
Message-ID: <Y7RY40+tAUOq97MQ@google.com> (raw)
In-Reply-To: <DS0PR11MB6373F27D0EE6CD28C784478BDCEC9@DS0PR11MB6373.namprd11.prod.outlook.com>
On Mon, Dec 26, 2022, Wang, Wei W wrote:
> On Saturday, December 24, 2022 1:14 AM, Paolo Bonzini wrote:
> > On 12/20/22 04:04, Wang, Wei W wrote:
> > > Another option is to let kvm_io_bus_unregister_dev handle this, and no
> > > need for callers to make the extra kvm_iodevice_destructor() call.
> > > This simplifies the usage for callers (e.g. reducing LOCs and no leakages like
> > this):
> >
> > Can you send this as a patch? Thanks!
>
> Sure. I can do it. I'm also fine if Sean would be interested in taking over the
> code
No thanks.
> (or anything I should do to keep his credits for the original fixing?)
No need. If anything, take my patch first so that the fix for stable kernels is
trivial. That's Paolo's call though.
next prev parent reply other threads:[~2023-01-03 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 17:19 [PATCH] KVM: Destroy target device if coalesced MMIO unregistration fails Sean Christopherson
2022-12-20 3:04 ` Wang, Wei W
2022-12-20 6:05 ` Binbin Wu
2022-12-23 17:13 ` Paolo Bonzini
2022-12-26 10:17 ` Wang, Wei W
2023-01-03 16:33 ` Sean Christopherson [this message]
2023-02-01 22:37 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7RY40+tAUOq97MQ@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liujingfeng@qianxin.com \
--cc=pbonzini@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox