From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED79C004D4 for ; Thu, 19 Jan 2023 18:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbjASSEi (ORCPT ); Thu, 19 Jan 2023 13:04:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbjASSEW (ORCPT ); Thu, 19 Jan 2023 13:04:22 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52064917F2 for ; Thu, 19 Jan 2023 10:04:20 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id z13so3038515plg.6 for ; Thu, 19 Jan 2023 10:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6y9K0iW1kRsBC/mddZwl+2pKXT9gEpvdM6yfT0kkWgs=; b=r9fJZq/zeW/QLHylZ/qOklEA+M/ydr2B8xBZjXEwFkHpy0aCVYSMNNy1tD1WfkDOOC y6YFPFcgEWjYuansLBaXKQwY4WySvpn56ULo9OdrimOyLnUiv8Gs694/scyejPJUTRTk g4SVDYZS4U0FAX3Gulz4JP5os+5PZj1vOpkCwsVYlycEFICQiK/K/HhuCTARMRE5hTUk RuqkGhamAm2xNHrb7y3RqpGdPyvj65feiY89D9/ENaMwayIraulyNx8lZgnMWguTB8PO U6pI2Pzx+FafGPNz7o3MgeSNR76GTkqm91A/RUXvKUTp07raLGJ2FSYgB4H07tZnc/qs sv0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6y9K0iW1kRsBC/mddZwl+2pKXT9gEpvdM6yfT0kkWgs=; b=u4b2sW9A+922TJUBGHlBmgTajNe9ljB+FQ5mLGct7QiSg+nVOUrJxMhkslXT5/P8g6 Y2kqbVgQky4uVVEjK7qnvl+vqHoutYFzipHDu357a5xzHQjgIiv2oMH501mX0LJYX8HA 6UvuLEdyA8d//gp8XA/k7mE8vcM5Fi9nCh9YionxC/35ZZV2Jk6IsgvLov61HNV3QJjb tiOse+HxebWNKM0JvpJw9EBi3yi8LsPCHiXI3sUP2bHM9IEuB46aK1uCjdzphoXXuucs 29h8nnf3NJbbwMFS4jGcknW6baIqZPj8DOh7o2kQr+/0fhdvezqLxhHR3yEmZbRn5pPa SCaQ== X-Gm-Message-State: AFqh2kqKhjraszt49ZMukTn31ORFVFohNBkW4oTpP6h5vskIvgY1u3AU nc2qFVheQ/URxE7nUrWbc8ZTbA== X-Google-Smtp-Source: AMrXdXvGfKSI5zWv++JoNn9fRL7W+6evxSd9BszfHZjsBxMUxXJrxIvsF/j70lLejwfrW/gJiiCmTw== X-Received: by 2002:a17:902:b10e:b0:191:4367:7fde with SMTP id q14-20020a170902b10e00b0019143677fdemr3136248plr.0.1674151459345; Thu, 19 Jan 2023 10:04:19 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id d4-20020a170902654400b0018bde2250fcsm23931663pln.203.2023.01.19.10.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 10:04:18 -0800 (PST) Date: Thu, 19 Jan 2023 18:04:15 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Yu Zhang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Michal Luczaj , David Woodhouse Subject: Re: [PATCH] KVM: x86: fix deadlock for KVM_XEN_EVTCHN_RESET Message-ID: References: <20221228110410.1682852-1-pbonzini@redhat.com> <20230119155800.fiypvvzoalnfavse@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jan 19, 2023, Paolo Bonzini wrote: > On Thu, Jan 19, 2023 at 6:57 PM Sean Christopherson wrote: > > > This change generates a build failure with error message: > > > "error: a label can only be part of a statement and a declaration is not a statement". > > > > And other flavors too, e.g. > > > > x86_64/xen_shinfo_test.c:965:2: error: expected expression > > struct kvm_xen_hvm_attr evt_reset = { > > ^ > > x86_64/xen_shinfo_test.c:969:38: error: use of undeclared identifier 'evt_reset' > > vm_ioctl(vm, KVM_XEN_HVM_SET_ATTR, &evt_reset); > > ^ > > x86_64/xen_shinfo_test.c:969:38: error: use of undeclared identifier 'evt_reset' > > 3 errors generated. > > make: *** [../lib.mk:145: tools/testing/selftests/kvm/x86_64/xen_shinfo_test] Error 1 > > make: *** Waiting for unfinished jobs.... > > > > I'm surprised bots haven't complained about this, haven't seen any reports. > > It's clang only; GCC only warns with -Wpedantic. Plus, bots probably > don't compile tools/ that much. /wave Want to queue Yu's fix directly Paolo? I was assuming you'd be offline until sometime tomorrow.