From: Greg KH <gregkh@linuxfoundation.org>
To: Kechen Lu <kechenl@nvidia.com>
Cc: kvm@vger.kernel.org, seanjc@google.com, pbonzini@redhat.com,
zhi.wang.linux@gmail.com, chao.gao@intel.com,
shaoqin.huang@intel.com, vkuznets@redhat.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [RFC PATCH v6 1/6] KVM: x86: only allow exits disable before vCPUs created
Date: Sat, 21 Jan 2023 08:28:00 +0100 [thread overview]
Message-ID: <Y8uUAFv9Qz7GvSei@kroah.com> (raw)
In-Reply-To: <20230121020738.2973-2-kechenl@nvidia.com>
On Sat, Jan 21, 2023 at 02:07:33AM +0000, Kechen Lu wrote:
> From: Sean Christopherson <seanjc@google.com>
>
> Since VMX and SVM both would never update the control bits if exits
> are disable after vCPUs are created, only allow setting exits
> disable flag before vCPU creation.
>
> Fixes: 4d5422cea3b6 ("KVM: X86: Provide a capability to disable MWAIT intercepts")
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
Nit, no blank line between fixes and signed-off-by please.
And an RFC on v6? An RFC usually means "I don't think this is correct
so do not take it". How can you do that for 6 versions? And know that
no one will take an RFC series for that reason (or at least I will
not...)
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-21 7:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 2:07 [RFC PATCH v6 0/6] KVM: x86: add per-vCPU exits disable capability Kechen Lu
2023-01-21 2:07 ` [RFC PATCH v6 1/6] KVM: x86: only allow exits disable before vCPUs created Kechen Lu
2023-01-21 7:28 ` Greg KH [this message]
2023-01-22 1:48 ` Kechen Lu
2023-01-21 2:07 ` [RFC PATCH v6 2/6] KVM: x86: Move *_in_guest power management flags to vCPU scope Kechen Lu
2023-02-02 14:56 ` Zhi Wang
2023-02-02 19:42 ` Kechen Lu
2023-01-21 2:07 ` [RFC PATCH v6 3/6] KVM: x86: Reject disabling of MWAIT interception when not allowed Kechen Lu
2023-01-31 12:11 ` Zhao Liu
2023-02-01 0:43 ` Kechen Lu
2023-01-21 2:07 ` [RFC PATCH v6 4/6] KVM: x86: Let userspace re-enable previously disabled exits Kechen Lu
2023-01-30 6:19 ` Chao Gao
2023-01-30 20:25 ` Kechen Lu
2023-01-21 2:07 ` [RFC PATCH v6 5/6] KVM: x86: add vCPU scoped toggling for " Kechen Lu
2023-01-30 6:42 ` Chao Gao
2023-01-30 20:57 ` Kechen Lu
2023-01-31 2:23 ` Chao Gao
2023-01-21 2:07 ` [RFC PATCH v6 6/6] KVM: selftests: Add tests for VM and vCPU cap KVM_CAP_X86_DISABLE_EXITS Kechen Lu
2023-02-02 15:08 ` Zhi Wang
2023-02-02 20:17 ` Kechen Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8uUAFv9Qz7GvSei@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chao.gao@intel.com \
--cc=kechenl@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shaoqin.huang@intel.com \
--cc=stable@vger.kernel.org \
--cc=vkuznets@redhat.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox