From: Oliver Upton <oliver.upton@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: shahuang@redhat.com, kvm@vger.kernel.org,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
David Matlack <dmatlack@google.com>,
"moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)"
<linux-arm-kernel@lists.infradead.org>,
"open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)"
<kvmarm@lists.linux.dev>,
"moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)"
<kvmarm@lists.cs.columbia.edu>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: selftests: Remove redundant setbuf()
Date: Fri, 3 Feb 2023 18:49:45 +0000 [thread overview]
Message-ID: <Y91XSZaRyqJjsg8o@google.com> (raw)
In-Reply-To: <Y91VV+WWrakREsN6@google.com>
On Fri, Feb 03, 2023 at 06:41:27PM +0000, Sean Christopherson wrote:
> On Fri, Feb 03, 2023, shahuang@redhat.com wrote:
> > From: Shaoqin Huang <shahuang@redhat.com>
> >
> > Since setbuf(stdout, NULL) has been called in kvm_util.c with
> > __attribute((constructor)). Selftests no need to setup it in their own
> > code.
> >
> > Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> > ---
>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
Thanks!
> Oliver/Marc, want to grab this one? I doubt there will be conflicts, but IIRC
> there are a handful of in-flight changes for aarch64/page_fault_test.c.
That is indeed the plan.
Applying patches for arm64 has taken a bit longer because I don't
yet have push access to kvmarm so I need Marc to pull from me. The net
effect is emailed thankyous are delayed by a few days, but that wont be
an issue going forward.
--
Thanks,
Oliver
next prev parent reply other threads:[~2023-02-03 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 6:10 [PATCH] KVM: selftests: Remove redundant setbuf() shahuang
2023-02-03 18:41 ` Sean Christopherson
2023-02-03 18:49 ` Oliver Upton [this message]
2023-02-03 21:30 ` Oliver Upton
2023-02-06 17:12 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y91XSZaRyqJjsg8o@google.com \
--to=oliver.upton@linux.dev \
--cc=dmatlack@google.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shahuang@redhat.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).