From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D82BC38142 for ; Fri, 27 Jan 2023 23:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232261AbjA0XAZ (ORCPT ); Fri, 27 Jan 2023 18:00:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232254AbjA0XAZ (ORCPT ); Fri, 27 Jan 2023 18:00:25 -0500 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EFC2118 for ; Fri, 27 Jan 2023 15:00:20 -0800 (PST) Date: Fri, 27 Jan 2023 23:00:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1674860418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mYLdYwB5jQRZGI5iBm1hnHKX7Hrdf384ZZi+I0v+a2E=; b=dd4FvyNZJoNCEZzOgoasM4a2U1imL9QCfVRFW7Pr65C3kLUrR3siX06u/knR7paTFV6w/N scMYf/OxelgJ7dXa5RxB1+q/E4FxC0pPnFvJTaLAK9sOd14z/nyIl3GuD9Hr4AbdoJBQ2E M16QyL10RAH4h3P3mgR0pFFGMa7CTv8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ricardo Koller Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, andrew.jones@linux.dev, pbonzini@redhat.com, maz@kernel.org, alexandru.elisei@arm.com, eric.auger@redhat.com, yuzenghui@huawei.com Subject: Re: [PATCH v2 4/4] KVM: selftests: aarch64: Test read-only PT memory regions Message-ID: References: <20230127214353.245671-1-ricarkol@google.com> <20230127214353.245671-5-ricarkol@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127214353.245671-5-ricarkol@google.com> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Ricardo, On Fri, Jan 27, 2023 at 09:43:53PM +0000, Ricardo Koller wrote: > Extend the read-only memslot tests in page_fault_test to test > read-only PT (Page table) memslots. Note that this was not allowed > before commit 406504c7b040 ("KVM: arm64: Fix S1PTW handling on RO > memslots") as all S1PTW faults were treated as writes which resulted > in an (unrecoverable) exception inside the guest. More of a style nit going forward (don't bother respinning): > Signed-off-by: Ricardo Koller > --- > .../selftests/kvm/aarch64/page_fault_test.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/page_fault_test.c b/tools/testing/selftests/kvm/aarch64/page_fault_test.c > index 2e2178a7d0d8..54680dc5887f 100644 > --- a/tools/testing/selftests/kvm/aarch64/page_fault_test.c > +++ b/tools/testing/selftests/kvm/aarch64/page_fault_test.c > @@ -829,8 +829,9 @@ static void help(char *name) > > #define TEST_RO_MEMSLOT(_access, _mmio_handler, _mmio_exits) \ > { \ > - .name = SCAT3(ro_memslot, _access, _with_af), \ > + .name = SCAT2(ro_memslot, _access), \ You should explicitly call out these sort of drive-by/opportunistic changes in the commit message as being just that reviewers don't get lost figuring out how it relates to the functional change of this patch. -- Thanks, Oliver