Re: [PATCH 08/24] kvm: x86/mmu: Add lockdep when setting a TDP MMU SPTE

Sean Christopherson
2021-01-20T20:01:54Z

On Tue, Jan 12, 2021, Ben Gardon wrote:
> Add lockdep to __tdp_mmu_set_spte to ensure that SPTEs are only modified
> under the MMU lock. This lockdep will be updated in future commits to
> reflect and validate changes to the TDP MMU's synchronization strategy.

I'd omit the "updated in future commits" justification. IMO this is a good
change even if we never build on it, and the extra justification would be
confusing if this is merged separately from the parallelization patches.

> No functional change intended.
>
> Reviewed-by: Peter Feiner <pfeiner@google.com>
>
> Signed-off-by: Ben Gardon <bgardon@google.com>

Reviewed-by: Sean Christopherson <seanjc@google.com>