* [PATCH] KVM: cleanup DR6/DR7 reserved bits checks
@ 2021-02-02 17:02 Paolo Bonzini
2021-02-02 18:27 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2021-02-02 17:02 UTC (permalink / raw)
To: linux-kernel, kvm; +Cc: seanjc
kvm_dr6_valid and kvm_dr7_valid check that bits 63:32 are zero. Using
them makes it easier to review the code for inconsistencies.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/x86/kvm/x86.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 97674204bf44..e52e38f8c74d 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4414,9 +4414,9 @@ static int kvm_vcpu_ioctl_x86_set_debugregs(struct kvm_vcpu *vcpu,
if (dbgregs->flags)
return -EINVAL;
- if (dbgregs->dr6 & ~0xffffffffull)
+ if (!kvm_dr6_valid(dbgregs->dr6))
return -EINVAL;
- if (dbgregs->dr7 & ~0xffffffffull)
+ if (!kvm_dr7_valid(dbgregs->dr7))
return -EINVAL;
memcpy(vcpu->arch.db, dbgregs->db, sizeof(vcpu->arch.db));
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: cleanup DR6/DR7 reserved bits checks
2021-02-02 17:02 [PATCH] KVM: cleanup DR6/DR7 reserved bits checks Paolo Bonzini
@ 2021-02-02 18:27 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2021-02-02 18:27 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: linux-kernel, kvm
On Tue, Feb 02, 2021, Paolo Bonzini wrote:
> kvm_dr6_valid and kvm_dr7_valid check that bits 63:32 are zero. Using
> them makes it easier to review the code for inconsistencies.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/x86/kvm/x86.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 97674204bf44..e52e38f8c74d 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4414,9 +4414,9 @@ static int kvm_vcpu_ioctl_x86_set_debugregs(struct kvm_vcpu *vcpu,
> if (dbgregs->flags)
> return -EINVAL;
>
> - if (dbgregs->dr6 & ~0xffffffffull)
Oof, you weren't kidding.
Reviewed-by: Sean Christopherson <seanjc@google.com>
> + if (!kvm_dr6_valid(dbgregs->dr6))
> return -EINVAL;
> - if (dbgregs->dr7 & ~0xffffffffull)
> + if (!kvm_dr7_valid(dbgregs->dr7))
> return -EINVAL;
>
> memcpy(vcpu->arch.db, dbgregs->db, sizeof(vcpu->arch.db));
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-02 18:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-02 17:02 [PATCH] KVM: cleanup DR6/DR7 reserved bits checks Paolo Bonzini
2021-02-02 18:27 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox