From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C496EC433E6 for ; Fri, 19 Feb 2021 12:05:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78CF364EC4 for ; Fri, 19 Feb 2021 12:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbhBSMEv (ORCPT ); Fri, 19 Feb 2021 07:04:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38489 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231173AbhBSMCp (ORCPT ); Fri, 19 Feb 2021 07:02:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613736079; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fWLnHPiFIN233EMx/9zN13PG+fjuD+081yp+85rEGDg=; b=MBQGfBGKhTKMYeVEFz8MFN3fDkLLHUjwm62zdOQZXjCYIqdl7a0JpZ5W/+FUBpSXZQpnhg YKQi87uu8hnDla06ZdaPN39XA2fsVGQK7Xr2M0QU/SYoEh7/FFPOA47X/krqaPQCu3cxni 5yUKclrGDY7CXJcXI0l/ZW+42XFotbc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-9adYdHpkOCaGhZODEykq9g-1; Fri, 19 Feb 2021 07:01:16 -0500 X-MC-Unique: 9adYdHpkOCaGhZODEykq9g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3CE5846208; Fri, 19 Feb 2021 12:00:52 +0000 (UTC) Received: from redhat.com (ovpn-113-184.ams2.redhat.com [10.36.113.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FCEA19C71; Fri, 19 Feb 2021 12:00:46 +0000 (UTC) Date: Fri, 19 Feb 2021 12:00:43 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Radoslaw Biernacki , kvm@vger.kernel.org, David Hildenbrand , Mark Cave-Ayland , Thomas Huth , "Edgar E. Iglesias" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?utf-8?B?SGVydsOp?= Poussineau , Leif Lindholm , Aleksandar Rikalo , Eduardo Habkost , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Subject: Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20210219114428.1936109-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210219114428.1936109-1-philmd@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Feb 19, 2021 at 12:44:21PM +0100, Philippe Mathieu-Daudé wrote: > Hi, > > This series aims to improve user experience by providing > a better error message when the user tries to enable KVM > on machines not supporting it. Improved error message is good, but it is better if the mgmt apps knows not to try this in the first place. IOW, I think we want "query-machines" to filter out machines which are not available with the currently configured accelerator. libvirt will probe separately with both TCG and KVM enabled, so if query-machines can give the right answer in these cases, libvirt will probably "just work" and not offer to even start such a VM. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|