From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB87C433DB for ; Wed, 24 Feb 2021 23:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C649564F07 for ; Wed, 24 Feb 2021 23:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236174AbhBXXOK (ORCPT ); Wed, 24 Feb 2021 18:14:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234728AbhBXXOJ (ORCPT ); Wed, 24 Feb 2021 18:14:09 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E749C061574 for ; Wed, 24 Feb 2021 15:13:29 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id u26so2338467pfn.6 for ; Wed, 24 Feb 2021 15:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=muWCsWrQoBXyu4MckQ9XwIgh71Pik8fohBKy8+YwG04=; b=eALgcZew2EajyVeA/DiBEfM4a24dApZHnvUSzXm8kKOfeR1mXWz+bNzjmsq3m/8hka aYPKhw/8/x67hSwUlOdFPiH6qFX9rkoBkdESplPOCsj+JbhWaEasMiAEJ8AgzYIAqm4p yp67ujCmh5HofiMxCbHagDi6aOpZ+DYHw/28E0B6cYsGbwJ2RKhYBUtvsLz9dMsfm8gl 1hwODTkdUw1wXyhfduiO3n9tXE81lWrCqXiRDudm/cd+QUo6Vx0uktrikPYHPySKbZ3v Y+quj12JNP7Ur3mxgMxUor82l251R8I8o3h1oJHehxxHbxjaCpy83dNl1o9exjZC+ZeX x6KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=muWCsWrQoBXyu4MckQ9XwIgh71Pik8fohBKy8+YwG04=; b=F2xQKLQlsltCtbQzjLznfw/lKw85PJ9rtFpxhnWBtAYF49mSIFupjGrL2o042elRwD qQaJQiLRlEXIGhJz/jY7YcGYRMKbXGe9SWLAtuFmQMo9PX8HgztkTmYyWOliiIAOUReX iV1/tdt1tTXxlHm1rurVhJN23JOpkWfx1T9HvurzgZR8Z+PoJkxOg6hJEeO+L1ir6uok q3WySxZcR1YG9PKz3z0nfjx+H1gAmrdVrerLVSFlqAgno2w3+WyPCVgtImtucMeAmmiG Y8K4DnBJhiz0FjhhH6d6kFJSMwglF/MzXZigSYzI9Ui6rxCGJ6ovfgqESiraIYq91Aak 6g+A== X-Gm-Message-State: AOAM532hTyPRg3umlmppIY0r0y4dVGSgRCM3QiLM/nhrh88V9Pf+1jba F/Bb8L2wnE2AjUkMSaUK6YNS9A== X-Google-Smtp-Source: ABdhPJyvL7EJ65szTm5CqCguT3Le4nTVYm9ifanT54NrHZFg7olEuboR95EaeuMWTGAASbHj1KswEQ== X-Received: by 2002:aa7:8c49:0:b029:1ed:c1dc:4421 with SMTP id e9-20020aa78c490000b02901edc1dc4421mr318307pfd.43.1614208408889; Wed, 24 Feb 2021 15:13:28 -0800 (PST) Received: from google.com ([2620:0:1008:10:94bf:1b67:285c:b7ce]) by smtp.gmail.com with ESMTPSA id o65sm2713167pfg.44.2021.02.24.15.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 15:13:28 -0800 (PST) Date: Wed, 24 Feb 2021 15:13:23 -0800 From: Vipin Sharma To: Randy Dunlap Cc: tj@kernel.org, thomas.lendacky@amd.com, brijesh.singh@amd.com, jon.grimm@amd.com, eric.vantassell@amd.com, pbonzini@redhat.com, hannes@cmpxchg.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, corbet@lwn.net, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, gingell@google.com, rientjes@google.com, dionnaglaze@google.com, kvm@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 2/2] cgroup: sev: Miscellaneous cgroup documentation. Message-ID: References: <20210218195549.1696769-1-vipinsh@google.com> <20210218195549.1696769-3-vipinsh@google.com> <71092e0e-5c72-924b-c848-8ae9a589f6b0@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71092e0e-5c72-924b-c848-8ae9a589f6b0@infradead.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Feb 19, 2021 at 11:02:41AM -0800, Randy Dunlap wrote: > > +++ b/Documentation/admin-guide/cgroup-v1/misc.rst > > @@ -0,0 +1 @@ > > +/Documentation/admin-guide/cgroup-v2.rst > What is the purpose of this (above) file? This new controller has both cgroup v1 and v2 support. Tejun suggested if we can point to v2 doc from v1. If this is not recommended approach I can add all of the v2 documention of misc controller here, let me know. I missed a heading and adding this file in cgroup-v1/index.rst. Fixed it now. > > + Limits can be set more than the capacity value in the misc.capacity > > higher than > Done > > +a process to a different cgroup do not move the charge to the destination > > does Done > > +Others > > ---- > > That underline is too short for "Others". > Fixed. > Try building this doc file, please. > > next-20210219/Documentation/admin-guide/cgroup-v2.rst:2196: WARNING: Unexpected indentation. > next-20210219/Documentation/admin-guide/cgroup-v2.rst:2203: WARNING: Unexpected indentation. > next-20210219/Documentation/admin-guide/cgroup-v2.rst:2210: WARNING: Unexpected indentation. > next-20210219/Documentation/admin-guide/cgroup-v2.rst:2232: WARNING: Title underline too short. > > Others > ---- > next-20210219/Documentation/admin-guide/cgroup-v2.rst:2232: WARNING: Title underline too short. > > > I think that the first 3 warnings are due to missing a blank line after :: > or they could have something to do with mixed tabs and spaces in the misc.* > properties descriptions. > Sorry, I was not familiar with Sphinx build and didn't build using that. I have fixed all of the above warnings. My next patch will reflect fixes. Thanks