From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A38C433E0 for ; Fri, 26 Feb 2021 00:45:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5983601FD for ; Fri, 26 Feb 2021 00:45:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbhBZApW (ORCPT ); Thu, 25 Feb 2021 19:45:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbhBZApU (ORCPT ); Thu, 25 Feb 2021 19:45:20 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56B6FC061574 for ; Thu, 25 Feb 2021 16:44:40 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id b8so1455986plh.0 for ; Thu, 25 Feb 2021 16:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h7jDxtZalASzyHkDmaEkhchEdLrcFz/khshrlyrri3k=; b=r0Vat1kAG1Bu8IcR6MpU+iBMvoP/CkYqLYmjE4WaZc7OQopnDifxmPEwhM4Hl9Xu+R DfA0l3YJSwplfvOnd8KvMYSLPBQFJw4o3zs16vafJuKuSCEGc38NbUqOHUFkKe73eqQ6 6O39RaxGP1JZIbL4Ocm7d7QY99PH99I49PbzgYkgx+3BO4GTD+3HSL3Px2CTjOUszVGh Z284h3NYwZOahyt56aEBLoOx3BxnC1S0+e5UyvHbyh/wpqMWz5z3b1HszmDpiBUeGy/5 65iBYeSvfvW/8N6xIHbzwpmS2G4F6ijOIRPc40qjTeVpswW1nTdTPGvEvTudOG/HtGc8 zoew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h7jDxtZalASzyHkDmaEkhchEdLrcFz/khshrlyrri3k=; b=tNzCeJIlLpJ5FcvnIveBgC9J+z0UVI6ESwP53AFte+iz94lTKqOtpffUYCllIH0T5F /17N6fx17c4JdDg+1cD0RW5503H1+0sqdjubCMSg1meysL7GwC+2OykcrV9oOdC0Dp/A So2hfuHqrdgI07QHES+myPOME68VvVvIbEE5qgM6NxjkNA6mLRHeRNNPTeyvcAQnbCov M8zeSqNRdsygFrHGajoMHMdhnCws08YfpmOG4zw0R0+dH/cbqZZT56Tq92QbhI6Ibb3y 8hwcj6i5ycqtPcGFtLE9qcrpBFI6c7jtpUjzLtd3Ymv/6utP073fFZUJuzCm5/dXm0SY SzSw== X-Gm-Message-State: AOAM5320C/yA7eHsMV2SSi9g8cigbb3RfLaQFz+Wg5+IC+oQoAaP241x LOAAA7opIel00KtT93xYk+TUUw== X-Google-Smtp-Source: ABdhPJwmtflgmUgWFwxajdco2lxGXTx2TGBqit52YW2hmQYM6h5P52xe7XelELD3tQdfepTS7hMl6w== X-Received: by 2002:a17:902:d202:b029:e4:55cd:dde8 with SMTP id t2-20020a170902d202b02900e455cddde8mr437517ply.51.1614300278242; Thu, 25 Feb 2021 16:44:38 -0800 (PST) Received: from google.com ([2620:15c:f:10:34c4:7c1d:f9ba:4576]) by smtp.gmail.com with ESMTPSA id i10sm8047735pgo.75.2021.02.25.16.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 16:44:37 -0800 (PST) Date: Thu, 25 Feb 2021 16:44:31 -0800 From: Sean Christopherson To: Dongli Zhang Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com Subject: Re: [PATCH 1/1] KVM: x86: remove incorrect comment on active_mmu_pages Message-ID: References: <20210223203707.1135-1-dongli.zhang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223203707.1135-1-dongli.zhang@oracle.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Feb 23, 2021, Dongli Zhang wrote: > The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a > list. This patch removes the incorrect comment on active_mmu_pages. Maybe change the last sentence to "Remove the misplaced comment, it's mostly stating the obvious anyways." It's more misplaced than flat out incorrect, e.g. the alternative would be to hoist the comment above mmu_page_hash. I like removing it though, IMO mmu_page_hash is the most obvious name out of the various structures that track shadow pages. With that tweak: Reviewed-by: Sean Christopherson > Signed-off-by: Dongli Zhang > --- > arch/x86/include/asm/kvm_host.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 84499aad01a4..318242512407 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -937,9 +937,6 @@ struct kvm_arch { > unsigned int indirect_shadow_pages; > u8 mmu_valid_gen; > struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES]; > - /* > - * Hash table of struct kvm_mmu_page. > - */ > struct list_head active_mmu_pages; > struct list_head zapped_obsolete_pages; > struct list_head lpage_disallowed_mmu_pages; > -- > 2.17.1 >