From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEBFC433E6 for ; Wed, 17 Mar 2021 20:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8F4364F40 for ; Wed, 17 Mar 2021 20:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233414AbhCQUFH (ORCPT ); Wed, 17 Mar 2021 16:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233343AbhCQUE6 (ORCPT ); Wed, 17 Mar 2021 16:04:58 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676FFC06175F for ; Wed, 17 Mar 2021 13:04:58 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id a22-20020a17090aa516b02900c1215e9b33so3815469pjq.5 for ; Wed, 17 Mar 2021 13:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BYZNRlPQkZnMRBL4a+EpgO4ozvN4OwEfHCiHjo/X4no=; b=ArsiJrv3lMSRFF9w2hbQtRHO2p6QIL4v6hTHmS5990wpKcwbZFU3PjJ8gw/lSMCR8o Evh3us3rWOGBlWtl21ED5RkiXK3u/0lhXiCAnSx8p75DtbbROq+RdGIaxjj4JLp6vFY1 vYFj41CzBTriZM1ZBuE3a4kcVh+MaKVvHlU6jWqjZHdyr68HFqjlj0jrfIf/5w0HdV+o MEnx/81FpMA7DD/h3XCRjZ0FNrv1mY3AOedY68nQhXRimuaB38htmP7XzmKkCzY0+gUc kiuD8UpPE7Vp+O7d77zwoUNutCiqqCo00UmGf3D7yTJdwmE+pzwmaFsHOe/PDBk+2arz 0BjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BYZNRlPQkZnMRBL4a+EpgO4ozvN4OwEfHCiHjo/X4no=; b=jbVK3Vxii635nkFu5ndCV4BvIcPoj4Hy7D0BGQRvg4EtjpSYeOzecwMP84sy2idCBS ExeICHCo7OL9eKC+nROHBJVwqrjVVufr5xO9FXmaab/vAqeo7ZHtpL7UeinI4fWG6gA1 2PbwwUP9fE9yzZhv43Zm3QfHUmWejWbyzmyLOvYBUTF7R/sjm+Ls3ELN2q22C2yTQkUc 9BgxwIZSVaXcX9UAITjifVmnectMGBtzc8gudea0Vv5P3mO5EzXzNn7kW+CXJGlXL/np gaQZiFTMLFRuuqEVTzN8vGv26gHWUAQ4ZO+KLt07tWr7/GZoy7wbtkCa1FAJfcCNnhpn oKXg== X-Gm-Message-State: AOAM532lPqGbmU6AJ5tbM+tivUZHvSEVNSLi6d0YuINnAO0eYuHoWLIX GLigpf9IdauHDHF0vCYbsuJLFQ== X-Google-Smtp-Source: ABdhPJya6VvchrfkLzaqvz1lzBesUntjlXZCteeCjukgygrX3dGib6g2gGR7BCTi+fjSWqHrqh3dew== X-Received: by 2002:a17:90a:8908:: with SMTP id u8mr496624pjn.135.1616011497400; Wed, 17 Mar 2021 13:04:57 -0700 (PDT) Received: from google.com ([2620:15c:f:10:e113:95c2:2d1:e304]) by smtp.gmail.com with ESMTPSA id a70sm19908917pfa.202.2021.03.17.13.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 13:04:56 -0700 (PDT) Date: Wed, 17 Mar 2021 13:04:50 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Graf , Yuan Yao Subject: Re: [PATCH 2/4] KVM: nVMX: Handle dynamic MSR intercept toggling Message-ID: References: <20210316184436.2544875-1-seanjc@google.com> <20210316184436.2544875-3-seanjc@google.com> <66bc75f6-58c5-c67f-f268-220d371022a2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Mar 17, 2021, Sean Christopherson wrote: > On Wed, Mar 17, 2021, Paolo Bonzini wrote: > > On 17/03/21 17:50, Sean Christopherson wrote: > > > > Feel free to squash patch 3 in this one or reorder it before; it makes sense > > > > to make them macros when you go from 4 to 6 functions. > > > I put them in a separate patch so that backporting the fix for the older FS/GS > > > nVMX bug was at least feasible. Not worth it? > > > > Going all the way back to 5.2 would almost certainly have other conflicts, > > so probably not. > > I'll do a dry run before posting v2; if it's clean I'll leave things as is, if > it's a mess I'll move the macro patch earlier. Backports to 5.4 (the olds relevant LTS) with a single trivial conflict on a function prototype (the function itself isn't touched, it's just an unfortunate false postive), and the MSR filtering selftest runs cleanly (in L1). I'll keep the original ordering unless you strongly prefer moving the macro patch earlier.